From patchwork Wed Aug 8 06:25:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: pingfan liu X-Patchwork-Id: 175867 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 58A9C2C0090 for ; Wed, 8 Aug 2012 17:01:29 +1000 (EST) Received: from localhost ([::1]:52105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sz0Gl-0002bt-Hz for incoming@patchwork.ozlabs.org; Wed, 08 Aug 2012 03:01:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyzjB-0001FO-R9 for qemu-devel@nongnu.org; Wed, 08 Aug 2012 02:26:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Syzj8-0002PL-6Q for qemu-devel@nongnu.org; Wed, 08 Aug 2012 02:26:45 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:62109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Syzj8-0001sm-23 for qemu-devel@nongnu.org; Wed, 08 Aug 2012 02:26:42 -0400 Received: by mail-ob0-f173.google.com with SMTP id ta14so635077obb.4 for ; Tue, 07 Aug 2012 23:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=GNMufsT0C5OBvU1I9FgQVpvsyNPc1p9doWu2JrzPCXA=; b=T9PNg2dEo+w5mqKGh/CRvDpHThLglQzEP3NnlwMxFm37EM6n9tOM+bOlBLmHXC9KF9 63bEp8ebNX00GyDZqtDosF5oEJDRslDB+9exmq7Yj8udavD0ep4hd7mLmdbly54JLl6t B1wLcgCF3rnhMW3FaDE80pubJ9g7kSSqa6YeIJRaOuGPJZKCqqnwP+p4p//WXc/f699I Xdl3ocgbQ6JdnYYVcZKiMZClN209K5trc6Bu0HSEz9exggnQ4KA/Dj15Gl645Pe87qLs +sDg6ZDBJ98N4qpl+IT1if5tscJLvU4Mey7wgiY4cTUnhc6FfqBeI9KbEoMsYj+4B/WB +Ckg== Received: by 10.60.29.228 with SMTP id n4mr28302494oeh.27.1344407201810; Tue, 07 Aug 2012 23:26:41 -0700 (PDT) Received: from localhost ([202.108.130.138]) by mx.google.com with ESMTPS id d6sm2240305obx.15.2012.08.07.23.26.39 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 07 Aug 2012 23:26:41 -0700 (PDT) From: Liu Ping Fan To: qemu-devel@nongnu.org Date: Wed, 8 Aug 2012 14:25:48 +0800 Message-Id: <1344407156-25562-8-git-send-email-qemulist@gmail.com> X-Mailer: git-send-email 1.7.4.4 In-Reply-To: <1344407156-25562-1-git-send-email-qemulist@gmail.com> References: <1344407156-25562-1-git-send-email-qemulist@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.173 Cc: kvm@vger.kernel.org, Stefan Hajnoczi , Marcelo Tosatti , qemulist@gmail.com, Blue Swirl , Avi Kivity , Anthony Liguori , Jan Kiszka , Paolo Bonzini , =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [Qemu-devel] [PATCH 07/15] memory: inc/dec mr's ref when adding/removing from mem view X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Liu Ping Fan memory_region_{add,del}_subregion will inc/dec mr's refcnt. Signed-off-by: Liu Ping Fan --- memory.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/memory.c b/memory.c index 5dc8b59..2eaa2fc 100644 --- a/memory.c +++ b/memory.c @@ -1356,7 +1356,7 @@ static void memory_region_add_subregion_common(MemoryRegion *mr, assert(!subregion->parent); subregion->parent = mr; subregion->addr = offset; - + memory_region_get(subregion); qemu_mutex_lock(&mem_map_lock); QTAILQ_FOREACH(other, &mr->subregions, subregions_link) { if (subregion->may_overlap || other->may_overlap) { @@ -1420,6 +1420,8 @@ void memory_region_del_subregion(MemoryRegion *mr, qemu_mutex_lock(&mem_map_lock); QTAILQ_REMOVE(&mr->subregions, subregion, subregions_link); memory_region_update_topology(mr); + /* mr may be still in use by reader of radix, must delay to release */ + memory_region_put(subregion); qemu_mutex_unlock(&mem_map_lock); }