Message ID | 200901092023.n09KN72t020166@imap1.linux-foundation.org |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
> On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <jeff@garzik.org> wrote: >> NAK - this fixes one set of users, and breaks a working set of users. >> >> Need to add DMI check for the specific motherboard (dmi_check_system), >> and flip flag according to success/failure of that check. > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> I'll just highlight this quoted bit for David... I've already posted a dmi_check_system() solution too -- you just need to fill in the motherboard details to fix the regression while keeping others' systems working. Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 09 Jan 2009 16:23:38 -0500 Jeff Garzik <jeff@garzik.org> wrote: > > On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <jeff@garzik.org> wrote: > >> NAK - this fixes one set of users, and breaks a working set of users. > >> > >> Need to add DMI check for the specific motherboard (dmi_check_system), > >> and flip flag according to success/failure of that check. > > > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> > > I'll just highlight this quoted bit for David... > > I've already posted a dmi_check_system() solution too What is the status of that? Where is it? > -- you just need > to fill in the motherboard details to fix the regression while keeping > others' systems working. Can you please tell Michael what info is needed to wrap this up? And how he is to obtain it? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Andrew Morton wrote: > On Fri, 09 Jan 2009 16:23:38 -0500 > Jeff Garzik <jeff@garzik.org> wrote: > >>> On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <jeff@garzik.org> wrote: >>>> NAK - this fixes one set of users, and breaks a working set of users. >>>> >>>> Need to add DMI check for the specific motherboard (dmi_check_system), >>>> and flip flag according to success/failure of that check. >>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> >> I'll just highlight this quoted bit for David... >> >> I've already posted a dmi_check_system() solution too > > What is the status of that? Where is it? You were CC'd on it each time... Here's a copy from the archives: http://www.mail-archive.com/netdev@vger.kernel.org/msg61096.html >> -- you just need >> to fill in the motherboard details to fix the regression while keeping >> others' systems working. > > Can you please tell Michael what info is needed to wrap this up? And > how he is to obtain it? I think he posted dmidecode output. I also think he said a BIOS update fixed the problem, at least according to the mail thread. Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: akpm@linux-foundation.org Date: Fri, 09 Jan 2009 12:23:07 -0800 > On Tue, 05 Feb 2008 13:20:59 -0500 Jeff Garzik <jeff@garzik.org> wrote: > > NAK - this fixes one set of users, and breaks a working set of users. > > > > Need to add DMI check for the specific motherboard (dmi_check_system), > > and flip flag according to success/failure of that check. > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org> I'm holding off on this until the DMI angle is worked out. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -puN drivers/net/forcedeth.c~forcedeth-fix-mac-address-detection-on-network-card-regression-in-2623 drivers/net/forcedeth.c --- a/drivers/net/forcedeth.c~forcedeth-fix-mac-address-detection-on-network-card-regression-in-2623 +++ a/drivers/net/forcedeth.c @@ -6087,7 +6087,7 @@ static struct pci_device_id pci_tbl[] = }, { /* MCP61 Ethernet Controller */ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_16), - .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX_V1|DEV_HAS_STATISTICS_V2|DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT|DEV_HAS_CORRECT_MACADDR, + .driver_data = DEV_NEED_TIMERIRQ|DEV_NEED_LINKTIMER|DEV_HAS_HIGH_DMA|DEV_HAS_POWER_CNTRL|DEV_HAS_MSI|DEV_HAS_PAUSEFRAME_TX_V1|DEV_HAS_STATISTICS_V2|DEV_HAS_TEST_EXTENDED|DEV_HAS_MGMT_UNIT, }, { /* MCP61 Ethernet Controller */ PCI_DEVICE(PCI_VENDOR_ID_NVIDIA, PCI_DEVICE_ID_NVIDIA_NVENET_17),