Patchwork 2.6.28-git1 gianfar compile failure (ppc).

login
register
mail settings
Submitter Andy Fleming
Date Jan. 9, 2009, 6:10 p.m.
Message ID <2acbd3e40901091010r38d221b5nc2b2c98b589e55cb@mail.gmail.com>
Download mbox | patch
Permalink /patch/17564/
State Not Applicable
Delegated to: David Miller
Headers show

Comments

Andy Fleming - Jan. 9, 2009, 6:10 p.m.
On Sun, Dec 28, 2008 at 11:41 PM, Dave Jones <davej@redhat.com> wrote:
> ERROR: "cacheable_memzero" [drivers/net/gianfar_driver.ko] undefined!
>
> Introduced in a22823e72a4821ce1d4a248fbd8f5a81795af339
>
> I guess that needs exporting for when gianfar is modular, but I've no
> idea how to export things from powerpc assembly.
>
>        Dave
>


This patch which was posted to linuxppc-dev should fix your bug:

From: Kumar Gala <galak@kernel.crashing.org>
Date: Tue, Jan 6, 2009 at 11:00 PM
Subject: [PATCH] powerpc: Export cacheable_memzero as its now used in a driver
To: linuxppc-dev@ozlabs.org


The Freescale PowerPC specific gianfar driver (gig-e) uses
cacheable_memzero for performance reasons we need to export
the symbol to allow the driver to be built as a module.

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 arch/powerpc/kernel/ppc_ksyms.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

--
1.5.6.5
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/arch/powerpc/kernel/ppc_ksyms.c b/arch/powerpc/kernel/ppc_ksyms.c
index dcec132..c8b27bb 100644
--- a/arch/powerpc/kernel/ppc_ksyms.c
+++ b/arch/powerpc/kernel/ppc_ksyms.c
@@ -165,6 +165,7 @@  EXPORT_SYMBOL(timer_interrupt);
 EXPORT_SYMBOL(irq_desc);
 EXPORT_SYMBOL(tb_ticks_per_jiffy);
 EXPORT_SYMBOL(cacheable_memcpy);
+EXPORT_SYMBOL(cacheable_memzero);
 #endif

 #ifdef CONFIG_PPC32