Patchwork [v3] fix info qtree indention

login
register
mail settings
Submitter Gerd Hoffmann
Date Aug. 7, 2012, 6:27 a.m.
Message ID <1344320840-17228-1-git-send-email-kraxel@redhat.com>
Download mbox | patch
Permalink /patch/175507/
State New
Headers show

Comments

Gerd Hoffmann - Aug. 7, 2012, 6:27 a.m.
Without the patch bus properties are are not in line with the other
properties:

[ ... ]
  dev: fw_cfg, id ""
    ctl_iobase = 0x510
    data_iobase = 0x511
      irq 0
      mmio ffffffffffffffff/0000000000000002
      mmio ffffffffffffffff/0000000000000001
[ ... ]

With the patch applied everything is lined up properly:

[ ... ]
  dev: fw_cfg, id ""
    ctl_iobase = 0x510
    data_iobase = 0x511
    irq 0
    mmio ffffffffffffffff/0000000000000002
    mmio ffffffffffffffff/0000000000000001
[ ... ]

Needed to make the autotest qtree parser happy.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/qdev-monitor.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Gerd Hoffmann - Aug. 15, 2012, 8:26 a.m.
On 08/07/12 08:27, Gerd Hoffmann wrote:
> Without the patch bus properties are are not in line with the other
> properties:
> 
> [ ... ]
>   dev: fw_cfg, id ""
>     ctl_iobase = 0x510
>     data_iobase = 0x511
>       irq 0
>       mmio ffffffffffffffff/0000000000000002
>       mmio ffffffffffffffff/0000000000000001
> [ ... ]
> 
> With the patch applied everything is lined up properly:
> 
> [ ... ]
>   dev: fw_cfg, id ""
>     ctl_iobase = 0x510
>     data_iobase = 0x511
>     irq 0
>     mmio ffffffffffffffff/0000000000000002
>     mmio ffffffffffffffff/0000000000000001
> [ ... ]
> 
> Needed to make the autotest qtree parser happy.

Ping?

cheers,
  Gerd
Gerd Hoffmann - Aug. 24, 2012, 6:11 a.m.
On 08/15/12 10:26, Gerd Hoffmann wrote:
> On 08/07/12 08:27, Gerd Hoffmann wrote:
>> Without the patch bus properties are are not in line with the other
>> properties:
>>
>> [ ... ]
>>   dev: fw_cfg, id ""
>>     ctl_iobase = 0x510
>>     data_iobase = 0x511
>>       irq 0
>>       mmio ffffffffffffffff/0000000000000002
>>       mmio ffffffffffffffff/0000000000000001
>> [ ... ]
>>
>> With the patch applied everything is lined up properly:
>>
>> [ ... ]
>>   dev: fw_cfg, id ""
>>     ctl_iobase = 0x510
>>     data_iobase = 0x511
>>     irq 0
>>     mmio ffffffffffffffff/0000000000000002
>>     mmio ffffffffffffffff/0000000000000001
>> [ ... ]
>>
>> Needed to make the autotest qtree parser happy.
> 
> Ping?

PingĀ²

This should go into 1.2 ...

cheers,
  Gerd

Patch

diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
index b22a37a..0588fbc 100644
--- a/hw/qdev-monitor.c
+++ b/hw/qdev-monitor.c
@@ -543,7 +543,7 @@  static void qdev_print(Monitor *mon, DeviceState *dev, int indent)
         qdev_print_props(mon, dev, DEVICE_CLASS(class)->props, indent);
         class = object_class_get_parent(class);
     } while (class != object_class_by_name(TYPE_DEVICE));
-    bus_print_dev(dev->parent_bus, mon, dev, indent + 2);
+    bus_print_dev(dev->parent_bus, mon, dev, indent);
     QLIST_FOREACH(child, &dev->child_bus, sibling) {
         qbus_print(mon, child, indent);
     }