From patchwork Tue Aug 7 05:59:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amerigo Wang X-Patchwork-Id: 175506 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 651242C008C for ; Tue, 7 Aug 2012 15:59:26 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752225Ab2HGF7Y (ORCPT ); Tue, 7 Aug 2012 01:59:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44909 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751897Ab2HGF7X (ORCPT ); Tue, 7 Aug 2012 01:59:23 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q775xLLU029236 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Aug 2012 01:59:21 -0400 Received: from cr0.redhat.com (vpn1-113-41.nay.redhat.com [10.66.113.41]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q775xHio015870; Tue, 7 Aug 2012 01:59:18 -0400 From: Cong Wang To: netdev@vger.kernel.org Cc: Cong Wang , David Miller , Stephen Hemminger Subject: [Resend PATCH 7/8] bridge: add some comments for NETDEV_RELEASE Date: Tue, 7 Aug 2012 13:59:09 +0800 Message-Id: <1344319149-13132-1-git-send-email-amwang@redhat.com> In-Reply-To: <20120806.135003.442648448779232464.davem@davemloft.net> References: <20120806.135003.442648448779232464.davem@davemloft.net> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add comments on why we don't notify NETDEV_RELEASE. Cc: David Miller Cc: Stephen Hemminger Signed-off-by: Cong Wang --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index 171fd6b..bf47d4f 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -427,6 +427,9 @@ int br_del_if(struct net_bridge *br, struct net_device *dev) if (!p || p->br != br) return -EINVAL; + /* We don't notify NETDEV_RELEASE event, as this will + * stop netconsole on the bridge. + */ del_nbp(p); spin_lock_bh(&br->lock);