Patchwork 3c59x: Use device_set_wakeup_enable

login
register
mail settings
Submitter Steffen Klassert
Date Jan. 9, 2009, 1:53 p.m.
Message ID <20090109135317.GC6473@bayes.mathematik.tu-chemnitz.de>
Download mbox | patch
Permalink /patch/17517/
State Accepted
Delegated to: David Miller
Headers show

Comments

Steffen Klassert - Jan. 9, 2009, 1:53 p.m.
Since dev->power.should_wakeup bit is used by the PCI core to
decide whether the device should wake up the system from sleep
states, set this bit by calling device_set_wakeup_enable().

This restores proper WOL for the 3c59x driver.

Reported-and-tested-by: Graeme Wilford <gwilford@gmail.com>
Reported-by: Gunnar Degnbol <degnbol@danbbs.dk>
Signed-off-by: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
---
 drivers/net/3c59x.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
David Miller - Jan. 10, 2009, 7:09 a.m.
From: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Date: Fri, 9 Jan 2009 14:53:17 +0100

> Since dev->power.should_wakeup bit is used by the PCI core to
> decide whether the device should wake up the system from sleep
> states, set this bit by calling device_set_wakeup_enable().
> 
> This restores proper WOL for the 3c59x driver.
> 
> Reported-and-tested-by: Graeme Wilford <gwilford@gmail.com>
> Reported-by: Gunnar Degnbol <degnbol@danbbs.dk>
> Signed-off-by: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/3c59x.c b/drivers/net/3c59x.c
index 665e7fd..cdbbb62 100644
--- a/drivers/net/3c59x.c
+++ b/drivers/net/3c59x.c
@@ -3109,6 +3109,8 @@  static void acpi_set_WOL(struct net_device *dev)
 	struct vortex_private *vp = netdev_priv(dev);
 	void __iomem *ioaddr = vp->ioaddr;
 
+	device_set_wakeup_enable(vp->gendev, vp->enable_wol);
+
 	if (vp->enable_wol) {
 		/* Power up on: 1==Downloaded Filter, 2==Magic Packets, 4==Link Status. */
 		EL3WINDOW(7);