Patchwork [v2] accounting: staticise accounting_sta_interim

login
register
mail settings
Submitter Baruch Siach
Date Aug. 5, 2012, 5:16 a.m.
Message ID <3f537906929211c56204204da3c05872b9824a2a.1344143540.git.baruch@tkos.co.il>
Download mbox | patch
Permalink /patch/175150/
State Accepted
Commit 37d428aef901b5680124f7dc0da34e067c391a0b
Headers show

Comments

Baruch Siach - Aug. 5, 2012, 5:16 a.m.
This routine is not used anywhere else.

Signed-hostap Baruch Siach <baruch@tkos.co.il>
---

v2: declare accounting_sta_interim at the beginning of accounting.c instead of 
    moving it, to avoid a warning due to accounting_sta_report() not being 
    declared.

 src/ap/accounting.c |    5 ++++-
 src/ap/accounting.h |    1 -
 2 files changed, 4 insertions(+), 2 deletions(-)
Jouni Malinen - Aug. 5, 2012, 4:42 p.m.
On Sun, Aug 05, 2012 at 08:16:07AM +0300, Baruch Siach wrote:
> This routine is not used anywhere else.

Thanks, applied.

Patch

diff --git a/src/ap/accounting.c b/src/ap/accounting.c
index 2c3a6d9..4b923ef 100644
--- a/src/ap/accounting.c
+++ b/src/ap/accounting.c
@@ -29,6 +29,8 @@ 
 static void accounting_sta_get_id(struct hostapd_data *hapd,
 				  struct sta_info *sta);
 
+static void accounting_sta_interim(struct hostapd_data *hapd,
+                   struct sta_info *sta);
 
 static struct radius_msg * accounting_msg(struct hostapd_data *hapd,
 					  struct sta_info *sta,
@@ -415,7 +417,8 @@  static void accounting_sta_report(struct hostapd_data *hapd,
  * @hapd: hostapd BSS data
  * @sta: The station
  */
-void accounting_sta_interim(struct hostapd_data *hapd, struct sta_info *sta)
+static void accounting_sta_interim(struct hostapd_data *hapd,
+				   struct sta_info *sta)
 {
 	if (sta->acct_session_started)
 		accounting_sta_report(hapd, sta, 0);
diff --git a/src/ap/accounting.h b/src/ap/accounting.h
index 797e24d..9d13d01 100644
--- a/src/ap/accounting.h
+++ b/src/ap/accounting.h
@@ -9,7 +9,6 @@ 
 #ifndef ACCOUNTING_H
 #define ACCOUNTING_H
 
-void accounting_sta_interim(struct hostapd_data *hapd, struct sta_info *sta);
 #ifdef CONFIG_NO_ACCOUNTING
 static inline void accounting_sta_start(struct hostapd_data *hapd,
 					struct sta_info *sta)