Patchwork tcp_output: fix sparse warning for tcp_wfree

login
register
mail settings
Submitter Silviu-Mihai Popescu
Date Aug. 4, 2012, 7:31 p.m.
Message ID <1344108689-17896-1-git-send-email-silviupopescu1990@gmail.com>
Download mbox | patch
Permalink /patch/175125/
State Accepted
Delegated to: David Miller
Headers show

Comments

Silviu-Mihai Popescu - Aug. 4, 2012, 7:31 p.m.
Fix sparse warning:
	* symbol 'tcp_wfree' was not declared. Should it be static?

Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
---
 net/ipv4/tcp_output.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
David Miller - Aug. 6, 2012, 8:30 p.m.
From: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>
Date: Sat,  4 Aug 2012 22:31:29 +0300

> Fix sparse warning:
> 	* symbol 'tcp_wfree' was not declared. Should it be static?
> 
> Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990@gmail.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/net/ipv4/tcp_output.c b/net/ipv4/tcp_output.c
index 3f1bcff..18475e0 100644
--- a/net/ipv4/tcp_output.c
+++ b/net/ipv4/tcp_output.c
@@ -940,7 +940,7 @@  void __init tcp_tasklet_init(void)
  * We cant xmit new skbs from this context, as we might already
  * hold qdisc lock.
  */
-void tcp_wfree(struct sk_buff *skb)
+static void tcp_wfree(struct sk_buff *skb)
 {
 	struct sock *sk = skb->sk;
 	struct tcp_sock *tp = tcp_sk(sk);