Patchwork [U-Boot,2/2] ARM: tegra: fix Ventana standalone build

login
register
mail settings
Submitter Stephen Warren
Date Aug. 3, 2012, 4:55 p.m.
Message ID <1344012904-9342-2-git-send-email-swarren@wwwdotorg.org>
Download mbox | patch
Permalink /patch/175024/
State Accepted
Commit cf46cdebdd24b8ecbbf8477d89a7fdff974b3b81
Delegated to: Albert ARIBAUD
Headers show

Comments

Stephen Warren - Aug. 3, 2012, 4:55 p.m.
From: Stephen Warren <swarren@nvidia.com>

Ventana always pulls in files from the Seaboard directory, so needs to
mkdir $(obj)../seaboard unconditionally. This fixes:

git clean -f -d -x
./MAKEALL ventana

"MAKEALL -s tegra20" passes without this change, because Seaboard
happens to be built before Ventana, and hence the directory has already
been created.

I believe the mkdir is only needed for out-of-tree builds, since the
seaboard directory is part of the source tree. However, since we always
build an SPL for Tegra now, which I believe is effectively an out-of-tree
build, we will always need this at some time. The overhead of just
uncondtionally executing the mkdir is minimal, and simplifies the
Makefile, since we don't need to code up the exact minimal condition to
execute the mkdir.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 board/nvidia/ventana/Makefile |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

Patch

diff --git a/board/nvidia/ventana/Makefile b/board/nvidia/ventana/Makefile
index 611520c..147d0bc 100644
--- a/board/nvidia/ventana/Makefile
+++ b/board/nvidia/ventana/Makefile
@@ -24,9 +24,7 @@ 
 
 include $(TOPDIR)/config.mk
 
-ifneq ($(OBJTREE),$(SRCTREE))
 $(shell mkdir -p $(obj)../seaboard)
-endif
 
 LIB	= $(obj)lib$(BOARD).o