Patchwork [BUG] BSOD on Win2003 Server when 64bit PCI resource is present

login
register
mail settings
Submitter Paolo Bonzini
Date Aug. 3, 2012, 4:29 p.m.
Message ID <501BFC51.5020005@redhat.com>
Download mbox | patch
Permalink /patch/175015/
State New
Headers show

Comments

Paolo Bonzini - Aug. 3, 2012, 4:29 p.m.
Il 26/07/2012 17:38, Alexey Korolev ha scritto:
> HI,
> 
> Current version of Seabios is causing blue screen on Windows2003 when 64bit PCI resource is present and occupies high memory.
> 
> BSOD Error code is: 0x000000A5 (0x02, 0xFFFFfADF6A446880, 0x1, 0xFFFFFADFAA34690)
> 
> The issue is localized, it is related to presence of 64bit resource in _CRS method.
> 
> If we disable a 64bit region from _CRS  the Win2003 load normally but this doesn't allow Windows to use 64bit resources.
> 
> At the moment I have no idea how to fix this. Please help! 

I wonder if Windows 2003 does not support ConcatenateResTemplate.  The patch below
is obviously wrong, but should let you check if this is the issue:

git diff src/acpi-dsdt.dsl

Paolo

Patch

diff --git a/src/acpi-dsdt.dsl b/src/acpi-dsdt.dsl
index 72dc7d8..11a9c92 100644
--- a/src/acpi-dsdt.dsl
+++ b/src/acpi-dsdt.dsl
@@ -175,9 +175,6 @@  DefinitionBlock (
                     0x00000000,         // Address Translation Offset
                     0x1EC00000,         // Address Length
                     ,, PW32, AddressRangeMemory, TypeStatic)
-            })
-            Name (CR64, ResourceTemplate ()
-            {
                 QWordMemory (ResourceProducer, PosDecode, MinFixed, MaxFixed, Cacheable, ReadWrite,
                     0x00000000,          // Address Space Granularity
                     0x8000000000,        // Address Range Minimum
@@ -221,20 +218,14 @@  DefinitionBlock (
 		Store (P0EL, PE32)
 		Store (P0LL, PL32)
 
-		If (LAnd(LEqual(P1SL, 0x00), LEqual(P1SH, 0x00))) {
-		    Return (CRES)
-		} Else {
 		    /* fixup 64bit pci io window */
-		    CreateQWordField (CR64,\_SB.PCI0.PW64._MIN, PS64)
-		    CreateQWordField (CR64,\_SB.PCI0.PW64._MAX, PE64)
-		    CreateQWordField (CR64,\_SB.PCI0.PW64._LEN, PL64)
+		    CreateQWordField (CRES,\_SB.PCI0.PW64._MIN, PS64)
+		    CreateQWordField (CRES,\_SB.PCI0.PW64._MAX, PE64)
+		    CreateQWordField (CRES,\_SB.PCI0.PW64._LEN, PL64)
 		    Store (P1S, PS64)
 		    Store (P1E, PE64)
 		    Store (P1L, PL64)
-		    /* add window and return result */
-		    ConcatenateResTemplate (CRES, CR64, Local0)
-		    Return (Local0)
-		}
+		    Return (CRES)
             }
         }
     }