From patchwork Fri Aug 3 14:23:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 175002 Return-Path: X-Original-To: incoming-imx@patchwork.ozlabs.org Delivered-To: patchwork-incoming-imx@bilbo.ozlabs.org Received: from merlin.infradead.org (unknown [IPv6:2001:4978:20e::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id AC82B2C0092 for ; Sat, 4 Aug 2012 00:26:24 +1000 (EST) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1SxImU-0003yj-AH; Fri, 03 Aug 2012 14:23:10 +0000 Received: from co1ehsobe001.messaging.microsoft.com ([216.32.180.184] helo=co1outboundpool.messaging.microsoft.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SxImR-0003yA-GF for linux-arm-kernel@lists.infradead.org; Fri, 03 Aug 2012 14:23:08 +0000 Received: from mail49-co1-R.bigfish.com (10.243.78.248) by CO1EHSOBE010.bigfish.com (10.243.66.73) with Microsoft SMTP Server id 14.1.225.23; Fri, 3 Aug 2012 14:23:04 +0000 Received: from mail49-co1 (localhost [127.0.0.1]) by mail49-co1-R.bigfish.com (Postfix) with ESMTP id 5A0D44A03DF; Fri, 3 Aug 2012 14:23:04 +0000 (UTC) X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPV:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-SpamScore: -2 X-BigFish: VS-2(zz98dI1432Izz1202hzzz2dh87h2a8h668h839h944hd25he96hf0ah107ah) X-FB-DOMAIN-IP-MATCH: fail Received: from mail49-co1 (localhost.localdomain [127.0.0.1]) by mail49-co1 (MessageSwitch) id 1344003781305532_30198; Fri, 3 Aug 2012 14:23:01 +0000 (UTC) Received: from CO1EHSMHS030.bigfish.com (unknown [10.243.78.227]) by mail49-co1.bigfish.com (Postfix) with ESMTP id 4459E480044; Fri, 3 Aug 2012 14:23:01 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by CO1EHSMHS030.bigfish.com (10.243.66.40) with Microsoft SMTP Server (TLS) id 14.1.225.23; Fri, 3 Aug 2012 14:23:00 +0000 Received: from az84smr01.freescale.net (10.64.34.197) by 039-SN1MMR1-004.039d.mgd.msft.net (10.84.1.14) with Microsoft SMTP Server (TLS) id 14.2.298.5; Fri, 3 Aug 2012 09:22:59 -0500 Received: from S2101-09.ap.freescale.net ([10.192.185.103]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id q73EMvbb030639; Fri, 3 Aug 2012 07:22:57 -0700 Date: Fri, 3 Aug 2012 22:23:04 +0800 From: Shawn Guo To: Sascha Hauer Subject: Re: [PATCH 1/2] ARM: imx: enable emi_slow_gate clock for imx5 Message-ID: <20120803142302.GD23791@S2101-09.ap.freescale.net> References: <1343919712-6240-1-git-send-email-shawn.guo@linaro.org> <20120803141108.GV1451@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120803141108.GV1451@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: sigmatel.com X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [216.32.180.184 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: stable@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+incoming-imx=patchwork.ozlabs.org@lists.infradead.org List-Id: linux-imx-kernel.lists.patchwork.ozlabs.org On Fri, Aug 03, 2012 at 04:11:08PM +0200, Sascha Hauer wrote: > Can we add a comment that emi_slow_gate is needed for the EIM interface? > It's not obvious from the datasheet and this information might help > people who want to clean up the now unconditionally enabled clocks. > Ok, will amend the following change. > Otherwise: > > Acked-by: Sascha Hauer > Thanks. diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c index 6eee32a..4bdcaa9 100644 --- a/arch/arm/mach-imx/clk-imx51-imx53.c +++ b/arch/arm/mach-imx/clk-imx51-imx53.c @@ -303,7 +303,7 @@ static void __init mx5_clocks_common_init(unsigned long rate_ckil, clk_prepare_enable(clk[aips_tz2]); /* fec */ clk_prepare_enable(clk[spba]); clk_prepare_enable(clk[emi_fast_gate]); /* fec */ - clk_prepare_enable(clk[emi_slow_gate]); + clk_prepare_enable(clk[emi_slow_gate]); /* eim */ clk_prepare_enable(clk[tmax1]); clk_prepare_enable(clk[tmax2]); /* esdhc2, fec */ clk_prepare_enable(clk[tmax3]); /* esdhc1, esdhc4 */