From patchwork Fri Aug 3 10:51:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 174979 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 87C152C00A0 for ; Fri, 3 Aug 2012 21:22:42 +1000 (EST) Received: from localhost ([::1]:42340 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxFUI-0002cP-TU for incoming@patchwork.ozlabs.org; Fri, 03 Aug 2012 06:52:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxFTd-0000kA-8f for qemu-devel@nongnu.org; Fri, 03 Aug 2012 06:51:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SxFTX-0005Nt-GP for qemu-devel@nongnu.org; Fri, 03 Aug 2012 06:51:29 -0400 Received: from e06smtp16.uk.ibm.com ([195.75.94.112]:56093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SxFTX-0005Nm-7X for qemu-devel@nongnu.org; Fri, 03 Aug 2012 06:51:23 -0400 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 3 Aug 2012 11:51:22 +0100 Received: from d06nrmr1307.portsmouth.uk.ibm.com (9.149.38.129) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 3 Aug 2012 11:51:20 +0100 Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q73ApKNC2560082 for ; Fri, 3 Aug 2012 11:51:20 +0100 Received: from d06av06.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q73ApJUS028815 for ; Fri, 3 Aug 2012 04:51:19 -0600 Received: from localhost (stefanha-thinkpad.manchester-maybrook.uk.ibm.com [9.174.219.145]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with ESMTP id q73ApIwF028774; Fri, 3 Aug 2012 04:51:19 -0600 From: Stefan Hajnoczi To: Anthony Liguori Date: Fri, 3 Aug 2012 11:51:06 +0100 Message-Id: <1343991066-9814-8-git-send-email-stefanha@linux.vnet.ibm.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1343991066-9814-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1343991066-9814-1-git-send-email-stefanha@linux.vnet.ibm.com> x-cbid: 12080310-3548-0000-0000-000002BACA36 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 195.75.94.112 Cc: Peter Maydell , qemu-devel@nongnu.org, Stefan Hajnoczi Subject: [Qemu-devel] [PATCH 7/7] exec.c: Remove out of date comment X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Peter Maydell Remove an out of date comment: this comment used to be attached to cpu_register_physical_memory_log(), before commit 0f0cb164 accidentally inserted a couple of other functions between the comment and its function. It is in any case obsolete since (a) the function arguments it refers to have been replaced with a single MemoryRegionSection* argument and (b) the inability to handle regions whose offset_within_address_space and offset_within_region aren't equally aligned was fixed as part of the rewrite of this code. Signed-off-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- exec.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/exec.c b/exec.c index e6ac3e7..a42a0b5 100644 --- a/exec.c +++ b/exec.c @@ -2240,14 +2240,6 @@ static void phys_sections_clear(void) phys_sections_nb = 0; } -/* register physical memory. - For RAM, 'size' must be a multiple of the target page size. - If (phys_offset & ~TARGET_PAGE_MASK) != 0, then it is an - io memory page. The address used when calling the IO function is - the offset from the start of the region, plus region_offset. Both - start_addr and region_offset are rounded down to a page boundary - before calculating this offset. This should not be a problem unless - the low bits of start_addr and region_offset differ. */ static void register_subpage(MemoryRegionSection *section) { subpage_t *subpage;