From patchwork Fri Aug 3 08:02:18 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Bosscher X-Patchwork-Id: 174939 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 7AC6C2C190B for ; Fri, 3 Aug 2012 18:02:57 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1344585777; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: MIME-Version:Received:From:Date:Message-ID:Subject:To: Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:Sender:Delivered-To; bh=Fg6IVra bYX/Pph/fvgcMpZmYrh8=; b=xTRMGZz8CnQwbMHRgZRME7cpnDCmq79WiSEfERs +KdZM0+xaS7HS5YnJvAiBKqdXOYNwlj3e5hQP99gXa7K97s6cxWBCv9yNNwBET2c 6jMLL5kCOny31TOF+7TP1K6UKrH085p9YH8ta1vFAjYWRwojiPuhLdNpnCoCm2w3 NPXo= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:MIME-Version:Received:From:Date:Message-ID:Subject:To:Content-Type:X-IsSubscribed:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=kl0rz+eCa2hwvNxRER8VWZBh+/UlMyN8N8PeBn8fsMEdGULmlB34TmpUUQJjKw XoOGrDgc0RXMUviLCBYhmHXF1F577LK0E7twoKugyvPPcBkTgl4yqwKERfdwla2s g8koaxihPGNSYMaAvsE6HeNIFXS6ZUCyG0MK55k0W9Ygs=; Received: (qmail 7103 invoked by alias); 3 Aug 2012 08:02:54 -0000 Received: (qmail 7092 invoked by uid 22791); 3 Aug 2012 08:02:53 -0000 X-SWARE-Spam-Status: No, hits=-4.2 required=5.0 tests=AWL, BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_FROM, KHOP_RCVD_TRUST, RCVD_IN_DNSWL_LOW, RCVD_IN_HOSTKARMA_YE, TW_CP X-Spam-Check-By: sourceware.org Received: from mail-lpp01m010-f47.google.com (HELO mail-lpp01m010-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Aug 2012 08:02:40 +0000 Received: by lags15 with SMTP id s15so207115lag.20 for ; Fri, 03 Aug 2012 01:02:39 -0700 (PDT) Received: by 10.152.102.137 with SMTP id fo9mr788304lab.35.1343980959035; Fri, 03 Aug 2012 01:02:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.45.72 with HTTP; Fri, 3 Aug 2012 01:02:18 -0700 (PDT) From: Steven Bosscher Date: Fri, 3 Aug 2012 10:02:18 +0200 Message-ID: Subject: [patch] one more sched-vis fix To: GCC Patches X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hello, I also need to handle SEQUENCE, of course, or slim dumping fails in targets with branch delay slots. But who knew SEQUENCE can also appear as a REG_NOTE value?! The cfgrtl.c fix is purely cosmetic and obvious. Bootstrapped&tested on powerpc64-unknown-linux-gnu. Committed as obvious. Ciao! Steven * sched-vis (print_pattern): Handle SEQUENCE also. * cfgrtl.c (print_rtl_with_bb): Do not print a newline between insns. free (start); Index: sched-vis.c =================================================================== --- sched-vis.c (revision 190016) +++ sched-vis.c (working copy) @@ -610,8 +610,19 @@ print_pattern (char *buf, const_rtx x, int verbose } break; case SEQUENCE: - /* Should never see SEQUENCE codes until after reorg. */ - gcc_unreachable (); + { + int i; + + sprintf (t1, "sequence{"); + for (i = 0; i < XVECLEN (x, 0); i++) + { + print_pattern (t2, XVECEXP (x, 0, i), verbose); + sprintf (t3, "%s%s;", t1, t2); + strcpy (t1, t3); + } + sprintf (buf, "%s}", t1); + } + break; case ASM_INPUT: sprintf (buf, "asm {%s}", XSTR (x, 0)); break; Index: cfgrtl.c =================================================================== --- cfgrtl.c (revision 190112) +++ cfgrtl.c (working copy) @@ -1958,10 +1958,9 @@ print_rtl_with_bb (FILE *outf, const_rtx rtx_first dump_bb_info (outf, bb, 0, dump_flags | TDF_COMMENT, false, true); if (df && (flags & TDF_DETAILS)) df_dump_bottom (bb, outf); + putc ('\n', outf); } } - - putc ('\n', outf); }