Patchwork Missing change from gcc/ada/system.ads

login
register
mail settings
Submitter Andris Pavenis
Date Aug. 3, 2012, 4:12 a.m.
Message ID <501B4FC3.6040503@wippies.com>
Download mbox | patch
Permalink /patch/174873/
State New
Headers show

Comments

Andris Pavenis - Aug. 3, 2012, 4:12 a.m.
Revision http://gcc.gnu.org/viewcvs?view=revision&revision=189772
added constant Support_Atomic_Primitives to the target specific
system-*.ads files. The default system.ads was not updated.

The included patch
- adds the missing constant
- removes constants not present in other system-*.ads files any more

Andris

2012-08-03  andris.pavenis@iki.fi  <andris.pavenis@iki.fi>

     * system.ads:  Support_Atomic_Primitives set to False,
         Remove outdated constants
Arnaud Charlet - Aug. 3, 2012, 6:32 a.m.
> Revision http://gcc.gnu.org/viewcvs?view=revision&revision=189772
> added constant Support_Atomic_Primitives to the target specific
> system-*.ads files. The default system.ads was not updated.
> 
> The included patch
> - adds the missing constant
> - removes constants not present in other system-*.ads files any more

This patch is NOT ok, system.ads is a special version, used for bootstraping
the compiler, and as such, has different constraints.

There is nothing to change here.

Arno
Andris Pavenis - Aug. 3, 2012, 1:49 p.m.
On 08/03/2012 09:32 AM, Arnaud Charlet wrote:
>> Revision http://gcc.gnu.org/viewcvs?view=revision&revision=189772
>> added constant Support_Atomic_Primitives to the target specific
>> system-*.ads files. The default system.ads was not updated.
>>
>> The included patch
>> - adds the missing constant
>> - removes constants not present in other system-*.ads files any more
> This patch is NOT ok, system.ads is a special version, used for bootstraping
> the compiler, and as such, has different constraints.
>
> There is nothing to change here.
It is however used when building libada if target specific version is not specified
in gcc/ada/gcc_interface/Makefile.in. In that case building libada fails due to missing
Support_Atomic_Primitives.

Andris
Arnaud Charlet - Aug. 3, 2012, 1:53 p.m.
> It is however used when building libada if target specific version is not
> specified
> in gcc/ada/gcc_interface/Makefile.in.

Well, then you should submit changes for Makefile.in for your
unsupported target. That being said, see below:

> In that case building libada fails due to missing Support_Atomic_Primitives.

Yes, this is a known issue, see PR 54125.

The fix is coming soon, and is quite different from your patch.

Arno

Patch

From e63ea85554db9c652070280161cd55a861d3b2db Mon Sep 17 00:00:00 2001
From: Andris Pavenis <andris.pavenis@iki.fi>
Date: Thu, 2 Aug 2012 21:18:39 +0300
Subject: [PATCH] Add constant Support_Atomic_Primitives to system.ads

Additionally remove contants not present for target
specific versions.
---
 gcc/ada/system.ads | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/gcc/ada/system.ads b/gcc/ada/system.ads
index d38a533..9cca2d5 100644
--- a/gcc/ada/system.ads
+++ b/gcc/ada/system.ads
@@ -136,7 +136,6 @@  private
    --  parameters is not too critical for the compiler version (e.g. we
    --  do not use floating-point anyway in the compiler).
 
-   AAMP                      : constant Boolean := False;
    Backend_Divide_Checks     : constant Boolean := False;
    Backend_Overflow_Checks   : constant Boolean := False;
    Command_Line_Args         : constant Boolean := True;
@@ -148,13 +147,13 @@  private
    Frontend_Layout           : constant Boolean := False;
    Machine_Overflows         : constant Boolean := False;
    Machine_Rounds            : constant Boolean := True;
-   OpenVMS                   : constant Boolean := False;
    Preallocated_Stacks       : constant Boolean := False;
    Signed_Zeros              : constant Boolean := True;
    Stack_Check_Default       : constant Boolean := False;
    Stack_Check_Probes        : constant Boolean := False;
    Stack_Check_Limits        : constant Boolean := False;
    Support_Aggregates        : constant Boolean := True;
+   Support_Atomic_Primitives : constant Boolean := False;
    Support_Composite_Assign  : constant Boolean := True;
    Support_Composite_Compare : constant Boolean := True;
    Support_Long_Shifts       : constant Boolean := True;
@@ -163,13 +162,4 @@  private
    Use_Ada_Main_Program_Name : constant Boolean := False;
    ZCX_By_Default            : constant Boolean := False;
 
-   --  Obsolete entries, to be removed eventually (bootstrap issues!)
-
-   Front_End_ZCX_Support     : constant Boolean := False;
-   High_Integrity_Mode       : constant Boolean := False;
-   Long_Shifts_Inlined       : constant Boolean := True;
-   Functions_Return_By_DSP   : constant Boolean := False;
-   Support_64_Bit_Divides    : constant Boolean := True;
-   GCC_ZCX_Support           : constant Boolean := False;
-
 end System;
-- 
1.7.11.2