Patchwork [RFC,01/12] qorum: Add GPL v2+ header file.

login
register
mail settings
Submitter Benoit Canet
Date Aug. 2, 2012, 10:16 a.m.
Message ID <1343902604-13981-2-git-send-email-benoit@irqsave.net>
Download mbox | patch
Permalink /patch/174713/
State New
Headers show

Comments

Benoit Canet - Aug. 2, 2012, 10:16 a.m.
Signed-off-by: Benoit Canet <benoit@irqsave.net>
---
 block/qorum.c |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 block/qorum.c
Eric Blake - Aug. 2, 2012, 2:04 p.m.
On 08/02/2012 04:16 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  block/qorum.c |   15 +++++++++++++++

s/qorum/quorum/ for the file name.

>  1 file changed, 15 insertions(+)
>  create mode 100644 block/qorum.c
> 
> diff --git a/block/qorum.c b/block/qorum.c
> new file mode 100644
> index 0000000..3341021
> --- /dev/null
> +++ b/block/qorum.c
> @@ -0,0 +1,15 @@
> +/*

> + */
> +
> 

What good is a patch that adds a file whose sole contents are a comment?
 This should not be an independent patch; please squash it into the
first commit that really adds contents to the file.
Benoît Canet - Aug. 2, 2012, 2:55 p.m.
Le Thursday 02 Aug 2012 à 08:04:46 (-0600), Eric Blake a écrit :
> On 08/02/2012 04:16 AM, Benoît Canet wrote:
> > Signed-off-by: Benoit Canet <benoit@irqsave.net>
> > ---
> >  block/qorum.c |   15 +++++++++++++++
> 
> s/qorum/quorum/ for the file name.
ack

> 
> >  1 file changed, 15 insertions(+)
> >  create mode 100644 block/qorum.c
> > 
> > diff --git a/block/qorum.c b/block/qorum.c
> > new file mode 100644
> > index 0000000..3341021
> > --- /dev/null
> > +++ b/block/qorum.c
> > @@ -0,0 +1,15 @@
> > +/*
> 
> > + */
> > +
> > 
> 
> What good is a patch that adds a file whose sole contents are a comment?
>  This should not be an independent patch; please squash it into the
> first commit that really adds contents to the file.
ack

> 
> -- 
> Eric Blake   eblake@redhat.com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
Andreas Färber - Aug. 2, 2012, 4:07 p.m.
Am 02.08.2012 12:16, schrieb Benoît Canet:
> Signed-off-by: Benoit Canet <benoit@irqsave.net>
> ---
>  block/qorum.c |   15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>  create mode 100644 block/qorum.c

Did you forget to add the header file, or did you mean source file? :)

Andreas
Benoît Canet - Aug. 2, 2012, 4:47 p.m.
> Did you forget to add the header file, or did you mean source file? :)
I was thinking "GPL header" when typing this line :)

Benoît

Patch

diff --git a/block/qorum.c b/block/qorum.c
new file mode 100644
index 0000000..3341021
--- /dev/null
+++ b/block/qorum.c
@@ -0,0 +1,15 @@ 
+/*
+ * Qorum Block filter
+ *
+ * Copyright (C) Nodalink, SARL. 2012
+ *
+ * Author:
+ *   Benoît Canet <benoit.canet@irqsave.net>
+ *
+ * Based on the design and code of blkverify.c (Copyright (C) 2010 IBM, Corp)
+ * and blkmirror.c (Copyright (C) 2011 Red Hat, Inc).
+ *
+ * This work is licensed under the terms of the GNU GPL, version 2 or later.
+ * See the COPYING file in the top-level directory.
+ */
+