Patchwork [for-1.2,1/4] qemu-thread: Let qemu_thread_is_self() return bool

login
register
mail settings
Submitter Andreas Färber
Date Aug. 2, 2012, 12:48 a.m.
Message ID <1343868517-11852-2-git-send-email-afaerber@suse.de>
Download mbox | patch
Permalink /patch/174623/
State New
Headers show

Comments

Andreas Färber - Aug. 2, 2012, 12:48 a.m.
qemu_cpu_is_self(), passing the return value through, will later be
adapted to return bool as well.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 qemu-thread-posix.c |    2 +-
 qemu-thread-win32.c |    2 +-
 qemu-thread.h       |    3 ++-
 3 files changed, 4 insertions(+), 3 deletions(-)
Stefan Weil - Aug. 2, 2012, 6:27 a.m.
Am 02.08.2012 02:48, schrieb Andreas Färber:
> qemu_cpu_is_self(), passing the return value through, will later be
> adapted to return bool as well.
>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>   qemu-thread-posix.c |    2 +-
>   qemu-thread-win32.c |    2 +-
>   qemu-thread.h       |    3 ++-
>   3 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
> index 9e1b5fb..8fbabda 100644
> --- a/qemu-thread-posix.c
> +++ b/qemu-thread-posix.c
> @@ -151,7 +151,7 @@ void qemu_thread_get_self(QemuThread *thread)
>       thread->thread = pthread_self();
>   }
>   
> -int qemu_thread_is_self(QemuThread *thread)
> +bool qemu_thread_is_self(QemuThread *thread)
>   {
>      return pthread_equal(pthread_self(), thread->thread);
>   }
> diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c
> index 3524c8b..177b398 100644
> --- a/qemu-thread-win32.c
> +++ b/qemu-thread-win32.c
> @@ -330,7 +330,7 @@ HANDLE qemu_thread_get_handle(QemuThread *thread)
>       return handle;
>   }
>   
> -int qemu_thread_is_self(QemuThread *thread)
> +bool qemu_thread_is_self(QemuThread *thread)
>   {
>       return GetCurrentThreadId() == thread->tid;
>   }
> diff --git a/qemu-thread.h b/qemu-thread.h
> index a78a8f2..05fdaaf 100644
> --- a/qemu-thread.h
> +++ b/qemu-thread.h
> @@ -2,6 +2,7 @@
>   #define __QEMU_THREAD_H 1
>   
>   #include <inttypes.h>
> +#include <stdbool.h>
>   
>   typedef struct QemuMutex QemuMutex;
>   typedef struct QemuCond QemuCond;
> @@ -42,7 +43,7 @@ void qemu_thread_create(QemuThread *thread,
>                           void *arg, int mode);
>   void *qemu_thread_join(QemuThread *thread);
>   void qemu_thread_get_self(QemuThread *thread);
> -int qemu_thread_is_self(QemuThread *thread);
> +bool qemu_thread_is_self(QemuThread *thread);
>   void qemu_thread_exit(void *retval);
>   
>   #endif

Reviewed-by: Stefan Weil <sw@weilnetz.de>
Andreas Färber - Aug. 2, 2012, 4:14 p.m.
Am 02.08.2012 08:27, schrieb Stefan Weil:
> Am 02.08.2012 02:48, schrieb Andreas Färber:
>> qemu_cpu_is_self(), passing the return value through, will later be
>> adapted to return bool as well.
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>>   qemu-thread-posix.c |    2 +-
>>   qemu-thread-win32.c |    2 +-
>>   qemu-thread.h       |    3 ++-
>>   3 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
>> index 9e1b5fb..8fbabda 100644
>> --- a/qemu-thread-posix.c
>> +++ b/qemu-thread-posix.c
>> @@ -151,7 +151,7 @@ void qemu_thread_get_self(QemuThread *thread)
>>       thread->thread = pthread_self();
>>   }
>>   -int qemu_thread_is_self(QemuThread *thread)
>> +bool qemu_thread_is_self(QemuThread *thread)
>>   {
>>      return pthread_equal(pthread_self(), thread->thread);
>>   }
>> diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c
>> index 3524c8b..177b398 100644
>> --- a/qemu-thread-win32.c
>> +++ b/qemu-thread-win32.c
>> @@ -330,7 +330,7 @@ HANDLE qemu_thread_get_handle(QemuThread *thread)
>>       return handle;
>>   }
>>   -int qemu_thread_is_self(QemuThread *thread)
>> +bool qemu_thread_is_self(QemuThread *thread)
>>   {
>>       return GetCurrentThreadId() == thread->tid;
>>   }
>> diff --git a/qemu-thread.h b/qemu-thread.h
>> index a78a8f2..05fdaaf 100644
>> --- a/qemu-thread.h
>> +++ b/qemu-thread.h
>> @@ -2,6 +2,7 @@
>>   #define __QEMU_THREAD_H 1
>>     #include <inttypes.h>
>> +#include <stdbool.h>
>>     typedef struct QemuMutex QemuMutex;
>>   typedef struct QemuCond QemuCond;
>> @@ -42,7 +43,7 @@ void qemu_thread_create(QemuThread *thread,
>>                           void *arg, int mode);
>>   void *qemu_thread_join(QemuThread *thread);
>>   void qemu_thread_get_self(QemuThread *thread);
>> -int qemu_thread_is_self(QemuThread *thread);
>> +bool qemu_thread_is_self(QemuThread *thread);
>>   void qemu_thread_exit(void *retval);
>>     #endif
> 
> Reviewed-by: Stefan Weil <sw@weilnetz.de>

Thanks, branch updated.

/-F

Patch

diff --git a/qemu-thread-posix.c b/qemu-thread-posix.c
index 9e1b5fb..8fbabda 100644
--- a/qemu-thread-posix.c
+++ b/qemu-thread-posix.c
@@ -151,7 +151,7 @@  void qemu_thread_get_self(QemuThread *thread)
     thread->thread = pthread_self();
 }
 
-int qemu_thread_is_self(QemuThread *thread)
+bool qemu_thread_is_self(QemuThread *thread)
 {
    return pthread_equal(pthread_self(), thread->thread);
 }
diff --git a/qemu-thread-win32.c b/qemu-thread-win32.c
index 3524c8b..177b398 100644
--- a/qemu-thread-win32.c
+++ b/qemu-thread-win32.c
@@ -330,7 +330,7 @@  HANDLE qemu_thread_get_handle(QemuThread *thread)
     return handle;
 }
 
-int qemu_thread_is_self(QemuThread *thread)
+bool qemu_thread_is_self(QemuThread *thread)
 {
     return GetCurrentThreadId() == thread->tid;
 }
diff --git a/qemu-thread.h b/qemu-thread.h
index a78a8f2..05fdaaf 100644
--- a/qemu-thread.h
+++ b/qemu-thread.h
@@ -2,6 +2,7 @@ 
 #define __QEMU_THREAD_H 1
 
 #include <inttypes.h>
+#include <stdbool.h>
 
 typedef struct QemuMutex QemuMutex;
 typedef struct QemuCond QemuCond;
@@ -42,7 +43,7 @@  void qemu_thread_create(QemuThread *thread,
                         void *arg, int mode);
 void *qemu_thread_join(QemuThread *thread);
 void qemu_thread_get_self(QemuThread *thread);
-int qemu_thread_is_self(QemuThread *thread);
+bool qemu_thread_is_self(QemuThread *thread);
 void qemu_thread_exit(void *retval);
 
 #endif