From patchwork Wed Aug 1 08:21:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: acpi: method: _PSS power dissipation levels can be equal to previous level Date: Tue, 31 Jul 2012 22:21:13 -0000 From: Colin King X-Patchwork-Id: 174400 Message-Id: <1343809274-4227-1-git-send-email-colin.king@canonical.com> To: fwts-devel@lists.ubuntu.com From: Colin Ian King With newer CPUs we are seeing _PSS power dissipation levels that are equal to the previous level and this is not necessarily an error in the _PSS data. For example: P-State 0: CPU 2501 Mhz, 35000 mW, latency 10 us, bus master latency 10 us. P-State 1: CPU 2500 Mhz, 35000 mW, latency 10 us, bus master latency 10 us. P-State 2: CPU 2400 Mhz, 33218 mW, latency 10 us, bus master latency 10 us. P-State 3: CPU 2300 Mhz, 31470 mW, latency 10 us, bus master latency 10 us. This patch only flags up an error of the level is greater than the previous level rather than greater or equal. Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Alex Hung --- src/acpi/method/method.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index 032f42e..9e81f07 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -2003,7 +2003,7 @@ static void method_test_PSS_return(fwts_framework *fw, char *name, ACPI_BUFFER * /* Sanity check descending power dissipation levels */ if ((i > 0) && (prev_power != 0) && - (pstate->Package.Elements[1].Integer.Value >= prev_power)) { + (pstate->Package.Elements[1].Integer.Value > prev_power)) { fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_PSSSubPackagePowerNotDecending", "_PSS P-State sub-package %d has a larger power dissipation " "setting than the previous sub-package.", i);