From patchwork Wed Aug 1 08:21:13 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 174400 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id C2E812C007A for ; Wed, 1 Aug 2012 18:21:21 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SwUBD-0007lG-EF for incoming@patchwork.ozlabs.org; Wed, 01 Aug 2012 08:21:19 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by chlorine.canonical.com with esmtp (Exim 4.71) (envelope-from ) id 1SwUB8-0007kl-Dh for fwts-devel@lists.ubuntu.com; Wed, 01 Aug 2012 08:21:14 +0000 Received: from cpc37-craw6-2-0-cust191.16-3.cable.virginmedia.com ([92.239.39.192] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SwUB8-00064w-Bm for fwts-devel@lists.ubuntu.com; Wed, 01 Aug 2012 08:21:14 +0000 From: Colin King To: fwts-devel@lists.ubuntu.com Subject: [PATCH] acpi: method: _PSS power dissipation levels can be equal to previous level Date: Wed, 1 Aug 2012 09:21:13 +0100 Message-Id: <1343809274-4227-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 1.7.10.4 X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.13 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: fwts-devel-bounces@lists.ubuntu.com Errors-To: fwts-devel-bounces@lists.ubuntu.com From: Colin Ian King With newer CPUs we are seeing _PSS power dissipation levels that are equal to the previous level and this is not necessarily an error in the _PSS data. For example: P-State 0: CPU 2501 Mhz, 35000 mW, latency 10 us, bus master latency 10 us. P-State 1: CPU 2500 Mhz, 35000 mW, latency 10 us, bus master latency 10 us. P-State 2: CPU 2400 Mhz, 33218 mW, latency 10 us, bus master latency 10 us. P-State 3: CPU 2300 Mhz, 31470 mW, latency 10 us, bus master latency 10 us. This patch only flags up an error of the level is greater than the previous level rather than greater or equal. Signed-off-by: Colin Ian King Acked-by: Keng-Yu Lin Acked-by: Alex Hung --- src/acpi/method/method.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acpi/method/method.c b/src/acpi/method/method.c index 032f42e..9e81f07 100644 --- a/src/acpi/method/method.c +++ b/src/acpi/method/method.c @@ -2003,7 +2003,7 @@ static void method_test_PSS_return(fwts_framework *fw, char *name, ACPI_BUFFER * /* Sanity check descending power dissipation levels */ if ((i > 0) && (prev_power != 0) && - (pstate->Package.Elements[1].Integer.Value >= prev_power)) { + (pstate->Package.Elements[1].Integer.Value > prev_power)) { fwts_failed(fw, LOG_LEVEL_MEDIUM, "Method_PSSSubPackagePowerNotDecending", "_PSS P-State sub-package %d has a larger power dissipation " "setting than the previous sub-package.", i);