From patchwork Tue Jul 31 10:31:20 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Will Newton X-Patchwork-Id: 174196 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 6DBFF2C0088 for ; Tue, 31 Jul 2012 20:31:32 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 18BB730BEF; Tue, 31 Jul 2012 10:31:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XG20pTJAj7wF; Tue, 31 Jul 2012 10:31:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 3E5A0271AD; Tue, 31 Jul 2012 10:31:25 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 10AD08F753 for ; Tue, 31 Jul 2012 10:31:23 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id F20AA8BAE6 for ; Tue, 31 Jul 2012 10:31:22 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id l8B2yHK-nzPw for ; Tue, 31 Jul 2012 10:31:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pb0-f43.google.com (mail-pb0-f43.google.com [209.85.160.43]) by whitealder.osuosl.org (Postfix) with ESMTPS id 92F108BAE0 for ; Tue, 31 Jul 2012 10:31:21 +0000 (UTC) Received: by pbcwz7 with SMTP id wz7so16674586pbc.16 for ; Tue, 31 Jul 2012 03:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=jxZyB7sRNGQZsE8I9XrT/aPmsM3qmyxuz/MpPDz2jIs=; b=aOrNpPIbwsmJmV5X4EYm2VKOHDwOEPwLYbUEPTLfdOnxgGdYHqBOZYgVgv1tE2DBgu DI7Op5X5EIW6zmvkGfoWfirM4CUtx0qJ50vgitUEOejMvy9CN62cq7RK+3+mVmfSSJee F6KE7sTOqUGG/Qy0EDOk4LIKWABd+hW1c2017jUkLxwDMQxzPxhrREFeHHMocqjalbHQ hNxAicTNX5So+HaHT7PilX9f2At6Bx9vR0qRf6QVfJzkwxvHLMnUmdLMS5EyD8kHyyFk lQ3dLrYAw+iqV95yqEfs7bGDCdg3rZty6tXY6UJpUEA1tXV1BbEG1Ny+3YkCFJs4UVl/ VGpA== MIME-Version: 1.0 Received: by 10.68.218.103 with SMTP id pf7mr43007089pbc.67.1343730681159; Tue, 31 Jul 2012 03:31:21 -0700 (PDT) Received: by 10.68.237.132 with HTTP; Tue, 31 Jul 2012 03:31:20 -0700 (PDT) In-Reply-To: <20120731110420.76490dd1@skate> References: <20120730235830.27770869@skate> <20120731110420.76490dd1@skate> Date: Tue, 31 Jul 2012 11:31:20 +0100 Message-ID: From: Will Newton To: Thomas Petazzoni Cc: buildroot@busybox.net Subject: Re: [Buildroot] [PATCH] sysprof: New package. X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net On Tue, Jul 31, 2012 at 10:04 AM, Thomas Petazzoni wrote: Hi Thomas, > Hello Will, > > Le Mon, 30 Jul 2012 23:58:30 +0200, > Thomas Petazzoni a écrit : > >> Le Fri, 27 Jul 2012 16:26:23 +0100, >> Will Newton a écrit : >> >> > Signed-off-by: Will Newton >> >> Applied, thanks. I did some changes to the package, though: >> >> - add dependencies on the supported architectures to avoid build >> failures on ARM and other unsupported arches >> - add a patch that removes an useless warning about the kernel >> version. This patch is present upstream. However since it >> modifies configure.ac, we need to autoreconf the package. >> - change AUTOTARGETS to autotools-package > > Unfortunately, the sysprof package has a number of build problems on > x86 and ppc. See: > > http://autobuild.buildroot.org/results/60728435af0221548c817cc8771674cc088e4d10/build-end.log > http://autobuild.buildroot.org/results/2d0ce96b30d32992d8f55f3a5974a81bbdb88915/build-end.log > > It has been causing quite a few build failures since I merged the > package, so it would be good to fix those. Would something like the below be acceptable? It's not very clean but until uClibc supports this define I don't know if there is a better alternative. uClibc does not define NT_GNU_BUILD_ID like glibc, so add a definition here until uClibc catches up. Signed-off-by: Will Newton --- package/sysprof/sysprof-02-uclibc-build-id.patch | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) create mode 100644 package/sysprof/sysprof-02-uclibc-build-id.patch diff --git a/package/sysprof/sysprof-02-uclibc-build-id.patch b/package/sysprof/sysprof-02-uclibc-build-id.patch new file mode 100644 index 0000000..932eba1 --- /dev/null +++ b/package/sysprof/sysprof-02-uclibc-build-id.patch @@ -0,0 +1,14 @@ +diff -u sysprof-1.1.8.old/elfparser.c sysprof-1.1.8/elfparser.c +--- sysprof-1.1.8.old/elfparser.c 2012-07-23 15:32:14.076213706 +0100 ++++ sysprof-1.1.8/elfparser.c 2012-07-23 15:33:49.092091443 +0100 +@@ -21,6 +21,10 @@ + #include + #include "elfparser.h" + ++#ifndef NT_GNU_BUILD_ID ++#define NT_GNU_BUILD_ID 3 ++#endif ++ + typedef struct Section Section; + + struct ElfSym