Patchwork sysprof: New package.

login
register
mail settings
Submitter Will Newton
Date July 31, 2012, 10:31 a.m.
Message ID <CAFbHwiQTT6rojCNvBNSUYierq5mrOkMmQfC95yxz1vK4gocCNA@mail.gmail.com>
Download mbox | patch
Permalink /patch/174196/
State Not Applicable
Headers show

Comments

Will Newton - July 31, 2012, 10:31 a.m.
On Tue, Jul 31, 2012 at 10:04 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:

Hi Thomas,

> Hello Will,
>
> Le Mon, 30 Jul 2012 23:58:30 +0200,
> Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a écrit :
>
>> Le Fri, 27 Jul 2012 16:26:23 +0100,
>> Will Newton <will.newton@gmail.com> a écrit :
>>
>> > Signed-off-by: Will Newton <will.newton@imgtec.com>
>>
>> Applied, thanks. I did some changes to the package, though:
>>
>>      - add dependencies on the supported architectures to avoid build
>>        failures on ARM and other unsupported arches
>>      - add a patch that removes an useless warning about the kernel
>>        version. This patch is present upstream. However since it
>>        modifies configure.ac, we need to autoreconf the package.
>>      - change AUTOTARGETS to autotools-package
>
> Unfortunately, the sysprof package has a number of build problems on
> x86 and ppc. See:
>
> http://autobuild.buildroot.org/results/60728435af0221548c817cc8771674cc088e4d10/build-end.log
> http://autobuild.buildroot.org/results/2d0ce96b30d32992d8f55f3a5974a81bbdb88915/build-end.log
>
> It has been causing quite a few build failures since I merged the
> package, so it would be good to fix those.

Would something like the below be acceptable? It's not very clean but
until uClibc supports this define I don't know if there is a better
alternative.


uClibc does not define NT_GNU_BUILD_ID like glibc, so add a
definition here until uClibc catches up.

Signed-off-by: Will Newton <will.newton@imgtec.com>
---
 package/sysprof/sysprof-02-uclibc-build-id.patch |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)
 create mode 100644 package/sysprof/sysprof-02-uclibc-build-id.patch
Thomas Petazzoni - July 31, 2012, 10:35 a.m.
Le Tue, 31 Jul 2012 11:31:20 +0100,
Will Newton <will.newton@gmail.com> a écrit :

> Would something like the below be acceptable? It's not very clean but
> until uClibc supports this define I don't know if there is a better
> alternative.

It's similar to
http://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-kernel/sysprof/files/define-NT_GNU_BUILD_ID.patch,
so I guess it's acceptable. The perf people are also doing the same
thing apparently.

Thanks, I will commit this!

Thomas
Thomas Petazzoni - Aug. 1, 2012, 8:03 a.m.
Le Tue, 31 Jul 2012 11:31:20 +0100,
Will Newton <will.newton@gmail.com> a écrit :

> > It has been causing quite a few build failures since I merged the
> > package, so it would be good to fix those.
> 
> Would something like the below be acceptable? It's not very clean but
> until uClibc supports this define I don't know if there is a better
> alternative.

I've pushed your patch. It solves the build failure on x86, and removes
one error message from the PowerPC build, but the PowerPC build is still
failing:
http://autobuild.buildroot.org/results/a3ef351704317a9f3f3ab4ee3845bc1e61938c23/build-end.log.

It has caused ~5 build failures during the last night.

Thanks!

Thomas
Thomas Petazzoni - Aug. 2, 2012, 7:19 a.m.
Le Wed, 1 Aug 2012 10:03:05 +0200,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> a écrit :

> I've pushed your patch. It solves the build failure on x86, and removes
> one error message from the PowerPC build, but the PowerPC build is still
> failing:
> http://autobuild.buildroot.org/results/a3ef351704317a9f3f3ab4ee3845bc1e61938c23/build-end.log.

I have pushed another patch (taken from upstream) that fixes this
problem, so no need to spend time on this one.

Thanks!

Thomas

Patch

diff --git a/package/sysprof/sysprof-02-uclibc-build-id.patch
b/package/sysprof/sysprof-02-uclibc-build-id.patch
new file mode 100644
index 0000000..932eba1
--- /dev/null
+++ b/package/sysprof/sysprof-02-uclibc-build-id.patch
@@ -0,0 +1,14 @@ 
+diff -u sysprof-1.1.8.old/elfparser.c sysprof-1.1.8/elfparser.c
+--- sysprof-1.1.8.old/elfparser.c	2012-07-23 15:32:14.076213706 +0100
++++ sysprof-1.1.8/elfparser.c	2012-07-23 15:33:49.092091443 +0100
+@@ -21,6 +21,10 @@
+ #include <sys/mman.h>
+ #include "elfparser.h"
+
++#ifndef NT_GNU_BUILD_ID
++#define NT_GNU_BUILD_ID 3
++#endif
++
+ typedef struct Section Section;
+
+ struct ElfSym