Patchwork protobuf: add license information

login
register
mail settings
Submitter Simon Dawson
Date July 31, 2012, 8:15 a.m.
Message ID <1343722559-10028-1-git-send-email-spdawson@gmail.com>
Download mbox | patch
Permalink /patch/174174/
State Superseded
Headers show

Comments

Simon Dawson - July 31, 2012, 8:15 a.m.
From: Simon Dawson <spdawson@gmail.com>

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/protobuf/protobuf.mk |    2 ++
 1 file changed, 2 insertions(+)
Baruch Siach - July 31, 2012, 8:30 a.m.
Hi Simon,

On Tue, Jul 31, 2012 at 09:15:59AM +0100, spdawson@gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
> 
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
>  package/protobuf/protobuf.mk |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> index 6e49dd3..653e90e 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -6,6 +6,8 @@
>  PROTOBUF_VERSION = 2.4.1
>  PROTOBUF_SOURCE = protobuf-$(PROTOBUF_VERSION).tar.gz
>  PROTOBUF_SITE = http://protobuf.googlecode.com/files/
> +PROTOBUF_LICENSE = PROPRIETARY

The text at https://code.google.com/p/protobuf/source/browse/trunk/COPYING.txt 
looks more like a 3-clause BSD licence (see 
http://en.wikipedia.org/wiki/BSD_licenses). Is this considered proprietary?

baruch

> +PROTOBUF_LICENSE_FILES = COPYING.txt
>  
>  # N.B. Need to use host protoc during cross compilation.
>  PROTOBUF_DEPENDENCIES = host-protobuf
> -- 
> 1.7.9.5
Simon Dawson - July 31, 2012, 8:36 a.m.
Hi Baruch, thanks for your feedback.

On 31 July 2012 09:30, Baruch Siach <baruch@tkos.co.il> wrote:
> The text at https://code.google.com/p/protobuf/source/browse/trunk/COPYING.txt
> looks more like a 3-clause BSD licence (see
> http://en.wikipedia.org/wiki/BSD_licenses). Is this considered proprietary?

You are right. I'll fix the license information, and resubmit.

Simon.
Luca Ceresoli - July 31, 2012, 8:38 a.m.
spdawson@gmail.com wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
>   package/protobuf/protobuf.mk |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
> index 6e49dd3..653e90e 100644
> --- a/package/protobuf/protobuf.mk
> +++ b/package/protobuf/protobuf.mk
> @@ -6,6 +6,8 @@
>   PROTOBUF_VERSION = 2.4.1
>   PROTOBUF_SOURCE = protobuf-$(PROTOBUF_VERSION).tar.gz
>   PROTOBUF_SITE = http://protobuf.googlecode.com/files/
> +PROTOBUF_LICENSE = PROPRIETARY

Hey, protobuf is licensed under the BSD-3c license.

Luca
Simon Dawson - July 31, 2012, 8:42 a.m.
On 31 July 2012 09:38, Luca Ceresoli <luca@lucaceresoli.net> wrote:
> Hey, protobuf is licensed under the BSD-3c license.

Thanks Luca; I've submitted an updated patch with the correct license
information.

Simon.

Patch

diff --git a/package/protobuf/protobuf.mk b/package/protobuf/protobuf.mk
index 6e49dd3..653e90e 100644
--- a/package/protobuf/protobuf.mk
+++ b/package/protobuf/protobuf.mk
@@ -6,6 +6,8 @@ 
 PROTOBUF_VERSION = 2.4.1
 PROTOBUF_SOURCE = protobuf-$(PROTOBUF_VERSION).tar.gz
 PROTOBUF_SITE = http://protobuf.googlecode.com/files/
+PROTOBUF_LICENSE = PROPRIETARY
+PROTOBUF_LICENSE_FILES = COPYING.txt
 
 # N.B. Need to use host protoc during cross compilation.
 PROTOBUF_DEPENDENCIES = host-protobuf