Patchwork wimax: fix kernel-doc for debufs_dentry member of struct wimax_dev [v2]

login
register
mail settings
Submitter Inaky Perez-Gonzalez
Date Jan. 8, 2009, 8:59 p.m.
Message ID <1231448396-8582-1-git-send-email-inaky@linux.intel.com>
Download mbox | patch
Permalink /patch/17415/
State Accepted
Delegated to: David Miller
Headers show

Comments

Inaky Perez-Gonzalez - Jan. 8, 2009, 8:59 p.m.
Reported by Randy Dunlap from a warning in the v2.6.29 merge window
tree as of 2009/1/8.

v2 fixes Randy Dunlap's email address.

Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
Cc: Randy Dunlap <randy.dunlap@oracle.com>
---
 include/net/wimax.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
Randy Dunlap - Jan. 9, 2009, 5:36 a.m.
Inaky Perez-Gonzalez wrote:
> Reported by Randy Dunlap from a warning in the v2.6.29 merge window
> tree as of 2009/1/8.
> 
> v2 fixes Randy Dunlap's email address.
> 
> Signed-off-by: Inaky Perez-Gonzalez <inaky@linux.intel.com>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  include/net/wimax.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/net/wimax.h b/include/net/wimax.h
> index 1602614..073809c 100644
> --- a/include/net/wimax.h
> +++ b/include/net/wimax.h
> @@ -323,6 +323,9 @@ struct input_dev;
>   *
>   * @rf_hw: [private] State of the hardware radio switch (OFF/ON)
>   *
> + * @debufs_dentry: [private] Used to hook up a debugfs entry. This
> + *     shows up in the debugfs root as wimax:DEVICENAME.

Inaky, this was supposed to be @debugfs_dentry.  (typo)

> + *
>   * Description:
>   * This structure defines a common interface to access all WiMAX
>   * devices from different vendors and provides a common API as well as
Inaky Perez-Gonzalez - Jan. 9, 2009, 7:23 a.m.
On Thursday 08 January 2009, Randy Dunlap wrote:
> Inaky Perez-Gonzalez wrote:
>...
> > diff --git a/include/net/wimax.h b/include/net/wimax.h
> > index 1602614..073809c 100644
> > --- a/include/net/wimax.h
> > +++ b/include/net/wimax.h
> > @@ -323,6 +323,9 @@ struct input_dev;
> >   *
> >   * @rf_hw: [private] State of the hardware radio switch (OFF/ON)
> >   *
> > + * @debufs_dentry: [private] Used to hook up a debugfs entry. This
> > + *     shows up in the debugfs root as wimax:DEVICENAME.
>
> Inaky, this was supposed to be @debugfs_dentry.  (typo)

Geeze, some days I really really really should not get out of bed and
much less get anywhere near anything with keys, not even a calculator.

Fix available in 
git://git.kernel.org/pub/scm/linux/kernel/git/inaky/wimax.git, patch coming.

Patch

diff --git a/include/net/wimax.h b/include/net/wimax.h
index 1602614..073809c 100644
--- a/include/net/wimax.h
+++ b/include/net/wimax.h
@@ -323,6 +323,9 @@  struct input_dev;
  *
  * @rf_hw: [private] State of the hardware radio switch (OFF/ON)
  *
+ * @debufs_dentry: [private] Used to hook up a debugfs entry. This
+ *     shows up in the debugfs root as wimax:DEVICENAME.
+ *
  * Description:
  * This structure defines a common interface to access all WiMAX
  * devices from different vendors and provides a common API as well as