Patchwork [Precise,SRU] UBUNTU: SAUCE: dell-laptop: additional rfkill blacklist Dell XPS 13

login
register
mail settings
Submitter Chris Van Hoof
Date July 30, 2012, 6:16 p.m.
Message ID <1343672183-20371-1-git-send-email-vanhoof@canonical.com>
Download mbox | patch
Permalink /patch/174071/
State New
Headers show

Comments

Chris Van Hoof - July 30, 2012, 6:16 p.m.
BugLink: https://bugs.launchpad.net/bugs/1030957

On the Dell XPS 13 (L322X), switching off Bluetooth also disables 
wifi. Fix-up by adding this model to the dell_blacklist table.

Signed-off-by: Chris Van Hoof <vanhoof@canonical.com>
Tested-by: Kent Baxley <kent.baxley@canonical.com>
Cc: Kamal Mostafa <kamal@canonical.com>
---
 drivers/platform/x86/dell-laptop.c |    8 ++++++++
 1 file changed, 8 insertions(+)
Tim Gardner - July 30, 2012, 8:39 p.m.
Are you gonna try to upstream this? I assume Quantal and R need the same
patch ?

rtg
Kamal Mostafa - July 30, 2012, 8:45 p.m.
On Mon, 2012-07-30 at 14:39 -0600, Tim Gardner wrote:
> Are you gonna try to upstream this? I assume Quantal and R need the same
> patch ?

No, we don't needs this one for Quantal or R -- only for Precise,
because the dell-laptop driver dropped this functionality (rfkill quirk)
recently.

 -Kamal
Seth Forshee - July 30, 2012, 8:49 p.m.
On Mon, Jul 30, 2012 at 02:16:23PM -0400, Chris Van Hoof wrote:
> BugLink: https://bugs.launchpad.net/bugs/1030957
> 
> On the Dell XPS 13 (L322X), switching off Bluetooth also disables 
> wifi. Fix-up by adding this model to the dell_blacklist table.
> 
> Signed-off-by: Chris Van Hoof <vanhoof@canonical.com>
> Tested-by: Kent Baxley <kent.baxley@canonical.com>
> Cc: Kamal Mostafa <kamal@canonical.com>
> ---
>  drivers/platform/x86/dell-laptop.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index f27a0b8..8f85ac2 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -127,6 +127,14 @@ static struct dmi_system_id __devinitdata dell_blacklist[] = {
>  			DMI_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L321X"),
>  		},
>  	},
> +	/* dell_laptop breaks rfkill behavior (LP: #1030957) */
> +	{
> +		.ident = "Dell XPS 13z",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L322X"),
> +		},
> +	},
>  	{
>  		.ident = "Dell XPS 15",
>  		.matches = {
> -- 
> 1.7.9.5
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Tim Gardner - July 30, 2012, 9:52 p.m.

Patch

diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
index f27a0b8..8f85ac2 100644
--- a/drivers/platform/x86/dell-laptop.c
+++ b/drivers/platform/x86/dell-laptop.c
@@ -127,6 +127,14 @@  static struct dmi_system_id __devinitdata dell_blacklist[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L321X"),
 		},
 	},
+	/* dell_laptop breaks rfkill behavior (LP: #1030957) */
+	{
+		.ident = "Dell XPS 13z",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L322X"),
+		},
+	},
 	{
 		.ident = "Dell XPS 15",
 		.matches = {