From patchwork Mon Jul 30 16:04:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [2/5] sparc: fix expression with uninitialized initial value From: Blue Swirl X-Patchwork-Id: 174034 Message-Id: <5ddedba0015c15117770b3d1860f7dd6d8d08a0c.1343664167.git.blauwirbel@gmail.com> To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com Date: Mon, 30 Jul 2012 16:04:32 +0000 From: Blue Swirl err was uninitalized, it's not OK to use |=. Spotted by Clang compiler. Fix by replacing |= by =. Signed-off-by: Blue Swirl Reviewed-by: Peter Maydell --- linux-user/signal.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 97f30d9..3d6b5df 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -2061,7 +2061,7 @@ restore_fpu_state(CPUSPARCState *env, qemu_siginfo_fpu_t *fpu) err = __copy_from_user(&env->fpr[0], &fpu->si_float_regs[0], (sizeof(unsigned long) * 32)); #endif - err |= __get_user(env->fsr, &fpu->si_fsr); + err = __get_user(env->fsr, &fpu->si_fsr); #if 0 err |= __get_user(current->thread.fpqdepth, &fpu->si_fpqdepth); if (current->thread.fpqdepth != 0)