Patchwork [pull,request] Pull request for branch for-2012.08/systemd

login
register
mail settings
Submitter Maxime Ripard
Date July 28, 2012, 7:21 a.m.
Message ID <cover.1343460025.git.maxime.ripard@free-electrons.com>
Download mbox
Permalink /patch/173832/
State Not Applicable
Headers show

Pull-request

git://git.free-electrons.com/users/maxime-ripard/buildroot.git for-2012.08/systemd

Comments

Maxime Ripard - July 28, 2012, 7:21 a.m.
The following changes since commit fd08153b9d677d654add6c580b9ccc5c27d672e2:

  Remove unused TARGET_ABI values (2012-07-25 20:27:58 +0200)

are available in the git repository at:

  git://git.free-electrons.com/users/maxime-ripard/buildroot.git for-2012.08/systemd

for you to fetch changes up to 6784a19dec70861969e093a123abe92f4ace3e56:

  doc: Update the documentation to mention the new PKG_INSTALL_INIT_ variables (2012-07-28 09:17:04 +0200)

----------------------------------------------------------------
Maxime Ripard (3):
      Rework of the init system
      Add systemd unit for lighttpd
      doc: Update the documentation to mention the new PKG_INSTALL_INIT_ variables

 docs/manual/adding-packages-generic.txt |    7 +++++++
 package/busybox/busybox.mk              |    7 +++++++
 package/lighttpd/lighttpd.mk            |   13 +++++++++++--
 package/lighttpd/lighttpd.service       |   10 ++++++++++
 package/pkg-generic.mk                  |    8 ++++++++
 target/generic/Config.in                |   25 +++++++++++++++++++++++++
 6 files changed, 68 insertions(+), 2 deletions(-)
 create mode 100644 package/lighttpd/lighttpd.service

Thanks,
Maxime Ripard - July 28, 2012, 7:30 a.m.
Hi,

I sent these patches a bit too quickly...

Basically, here, not much changed since version 3 of this pull request,
since I didn't have any comment on it, except a private comment from
Thomas to add the new _INSTALL_INIT_ variables to the documentation,
which I did.

Maxime

Le 28/07/2012 09:21, Maxime Ripard a écrit :
> The following changes since commit fd08153b9d677d654add6c580b9ccc5c27d672e2:
> 
>   Remove unused TARGET_ABI values (2012-07-25 20:27:58 +0200)
> 
> are available in the git repository at:
> 
>   git://git.free-electrons.com/users/maxime-ripard/buildroot.git for-2012.08/systemd
> 
> for you to fetch changes up to 6784a19dec70861969e093a123abe92f4ace3e56:
> 
>   doc: Update the documentation to mention the new PKG_INSTALL_INIT_ variables (2012-07-28 09:17:04 +0200)
> 
> ----------------------------------------------------------------
> Maxime Ripard (3):
>       Rework of the init system
>       Add systemd unit for lighttpd
>       doc: Update the documentation to mention the new PKG_INSTALL_INIT_ variables
> 
>  docs/manual/adding-packages-generic.txt |    7 +++++++
>  package/busybox/busybox.mk              |    7 +++++++
>  package/lighttpd/lighttpd.mk            |   13 +++++++++++--
>  package/lighttpd/lighttpd.service       |   10 ++++++++++
>  package/pkg-generic.mk                  |    8 ++++++++
>  target/generic/Config.in                |   25 +++++++++++++++++++++++++
>  6 files changed, 68 insertions(+), 2 deletions(-)
>  create mode 100644 package/lighttpd/lighttpd.service
> 
> Thanks,
>
Thomas Petazzoni - July 30, 2012, 9:21 p.m.
Le Sat, 28 Jul 2012 09:21:19 +0200,
Maxime Ripard <maxime.ripard@free-electrons.com> a écrit :

> Maxime Ripard (3):
>       Rework of the init system
>       Add systemd unit for lighttpd
>       doc: Update the documentation to mention the new PKG_INSTALL_INIT_ variables

I have applied your changes. I had to make a change on PATCH 1/3,
because the systemd init choice was visible even if the requirements
for the systemd package were not met (thread support and
udev-based /dev).

Also, it would be good to investigate the newer versions of systemd. If
I remember correctly, they integrate udev directly, but is it possible
to still have udev separately? This of course will not be for 2012.08,
but it would be nice to continue to integrate those technologies into
Buildroot.

Also, in the testing I've done with the vexpress Qemu target, I have
not been particularly impressed by the boot speed, but I should
probably try on a real target.

And final comment: it seems lighttpd is started even before the web
server is accessed. Wasn't systemd supposed to start such daemons
on-demand? Or maybe lighttpd does not have the necessary code to
support such kind of startup where the already opened socket is passed
by systemd?

Thanks!

Thomas
Maxime Ripard - Aug. 1, 2012, 9:18 a.m.
Hi,

Le 30/07/2012 23:21, Thomas Petazzoni a écrit :
> Le Sat, 28 Jul 2012 09:21:19 +0200,
> Maxime Ripard <maxime.ripard@free-electrons.com> a écrit :
> 
>> Maxime Ripard (3):
>>       Rework of the init system
>>       Add systemd unit for lighttpd
>>       doc: Update the documentation to mention the new PKG_INSTALL_INIT_ variables
> 
> I have applied your changes. I had to make a change on PATCH 1/3,
> because the systemd init choice was visible even if the requirements
> for the systemd package were not met (thread support and
> udev-based /dev).

Thanks!

> Also, it would be good to investigate the newer versions of systemd. If
> I remember correctly, they integrate udev directly, but is it possible
> to still have udev separately? This of course will not be for 2012.08,
> but it would be nice to continue to integrate those technologies into
> Buildroot.

Yes, this is definitely something I want to try in the future. They told
when they merged udev that we could still be able to compile both
separately, but from a quick look, I haven't seen a way to do so yet.

> Also, in the testing I've done with the vexpress Qemu target, I have
> not been particularly impressed by the boot speed, but I should
> probably try on a real target.

Yes, boot speed for a minimal system didn't impress me much neither. But
still, it tends to be the same time as with busybox's init, but it has
way much to boot, like udev, dbus, and so on. Also, if I remember
correctly the talk at ELCE last year from Koen Kooi, he was saying that
now the boot is mostly CPU-bound, which might explain the not-so-fast
boot on slow cpus.

> And final comment: it seems lighttpd is started even before the web
> server is accessed. Wasn't systemd supposed to start such daemons
> on-demand? Or maybe lighttpd does not have the necessary code to
> support such kind of startup where the already opened socket is passed
> by systemd?

This is one of the features of systemd yes, but the daemons have to be
started in inet-mode, so that it's actually systemd that handles the
socket. Here, we just start lighttpd like a regular daemon, so except
for the starting part, it has nothing to do with the daemon.

Maxime