Patchwork [14/27] error: drop functions used to get error data

login
register
mail settings
Submitter Luiz Capitulino
Date July 27, 2012, 9:31 p.m.
Message ID <1343424728-22461-15-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/173796/
State New
Headers show

Comments

Luiz Capitulino - July 27, 2012, 9:31 p.m.
They are not used anymore and all current errors' data are going to
be dropped.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 error.c     | 23 -----------------------
 error.h     | 10 ----------
 error_int.h |  1 -
 3 files changed, 34 deletions(-)

Patch

diff --git a/error.c b/error.c
index cdeeafe..b9d9b64 100644
--- a/error.c
+++ b/error.c
@@ -64,29 +64,6 @@  const char *error_get_pretty(Error *err)
     return err->msg;
 }
 
-const char *error_get_field(Error *err, const char *field)
-{
-    if (strcmp(field, "class") == 0) {
-        return qdict_get_str(err->obj, field);
-    } else {
-        QDict *dict = qdict_get_qdict(err->obj, "data");
-        return qdict_get_str(dict, field);
-    }
-}
-
-QDict *error_get_data(Error *err)
-{
-    QDict *data = qdict_get_qdict(err->obj, "data");
-    QINCREF(data);
-    return data;
-}
-
-void error_set_field(Error *err, const char *field, const char *value)
-{
-    QDict *dict = qdict_get_qdict(err->obj, "data");
-    qdict_put(dict, field, qstring_from_str(value));
-}
-
 void error_free(Error *err)
 {
     if (err) {
diff --git a/error.h b/error.h
index 45ff6c1..592a734 100644
--- a/error.h
+++ b/error.h
@@ -45,16 +45,6 @@  Error *error_copy(const Error *err);
 const char *error_get_pretty(Error *err);
 
 /**
- * Get an individual named error field.
- */
-const char *error_get_field(Error *err, const char *field);
-
-/**
- * Get an individual named error field.
- */
-void error_set_field(Error *err, const char *field, const char *value);
-
-/**
  * Propagate an error to an indirect pointer to an error.  This function will
  * always transfer ownership of the error reference and handles the case where
  * dst_err is NULL correctly.
diff --git a/error_int.h b/error_int.h
index 5e39424..4b00d08 100644
--- a/error_int.h
+++ b/error_int.h
@@ -22,7 +22,6 @@ 
  *
  * These are used to convert QErrors to Errors
  */
-QDict *error_get_data(Error *err);
 QObject *error_get_qobject(Error *err);
 void error_set_qobject(Error **errp, QObject *obj);