Patchwork qlge: Add offload features to vlan interfaces

login
register
mail settings
Submitter brenohl@br.ibm.com
Date July 27, 2012, 6:54 p.m.
Message ID <1343415292-49323-1-git-send-email-brenohl@br.ibm.com>
Download mbox | patch
Permalink /patch/173760/
State Accepted
Delegated to: David Miller
Headers show

Comments

brenohl@br.ibm.com - July 27, 2012, 6:54 p.m.
This patch fills the net_device vlan_features with the proper hardware features,
thus, improving the vlan interface performance.

With the patch applied, I can see around 148% improvement on a TCP_STREAM test,
from 3.5 Gb/s to 8.7 Gb/s. On TCP_RR, I see a 11% improvement, from 18k
to 20. The CPU utilization is almost the same on both cases, from the comparison
above.

Signed-off-by: Breno Leitao <brenohl@br.ibm.com>
David Miller - July 30, 2012, 6:18 a.m.
From: brenohl@br.ibm.com
Date: Fri, 27 Jul 2012 13:54:52 -0500

> This patch fills the net_device vlan_features with the proper hardware features,
> thus, improving the vlan interface performance.
> 
> With the patch applied, I can see around 148% improvement on a TCP_STREAM test,
> from 3.5 Gb/s to 8.7 Gb/s. On TCP_RR, I see a 11% improvement, from 18k
> to 20. The CPU utilization is almost the same on both cases, from the comparison
> above.
> 
> Signed-off-by: Breno Leitao <brenohl@br.ibm.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/ethernet/qlogic/qlge/qlge_main.c b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
index 3769f57..b53a3b6 100644
--- a/drivers/net/ethernet/qlogic/qlge/qlge_main.c
+++ b/drivers/net/ethernet/qlogic/qlge/qlge_main.c
@@ -4682,6 +4682,7 @@  static int __devinit qlge_probe(struct pci_dev *pdev,
 		NETIF_F_HW_VLAN_TX | NETIF_F_RXCSUM;
 	ndev->features = ndev->hw_features |
 		NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER;
+	ndev->vlan_features = ndev->hw_features;
 
 	if (test_bit(QL_DMA64, &qdev->flags))
 		ndev->features |= NETIF_F_HIGHDMA;