Patchwork [Precise] ideapad: generate valid key event only

login
register
mail settings
Submitter Jesse Sung
Date July 27, 2012, 9:40 a.m.
Message ID <1343382017-10613-1-git-send-email-jesse.sung@canonical.com>
Download mbox | patch
Permalink /patch/173610/
State New
Headers show

Comments

Jesse Sung - July 27, 2012, 9:40 a.m.
From: Ike Panhc <ike.pan@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1029834

Otherwise will generate KEY_UNKNOWN on un-listed vpc event,
which means nothing and is hard for user to report the detail
of the event.

Signed-off-by: Ike Panhc <ike.pan@canonical.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
(cherry picked from commit 20a769c1c6671d3b8d18a7358eff15e3dd29e94b)
Signed-off-by: Wen-chien Jesse Sung <jesse.sung@canonical.com>
---
 drivers/platform/x86/ideapad-laptop.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
Herton Ronaldo Krzesinski - July 27, 2012, 1:20 p.m.

Stefan Bader - July 27, 2012, 1:54 p.m.

Tim Gardner - July 27, 2012, 2:45 p.m.

Patch

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index a36addf..a1d1415 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -785,6 +785,10 @@  static void ideapad_acpi_notify(struct acpi_device *adevice, u32 event)
 			case 9:
 				ideapad_sync_rfk_state(priv);
 				break;
+			case 13:
+			case 6:
+				ideapad_input_report(priv, vpc_bit);
+				break;
 			case 4:
 				ideapad_backlight_notify_brightness(priv);
 				break;
@@ -795,7 +799,7 @@  static void ideapad_acpi_notify(struct acpi_device *adevice, u32 event)
 				ideapad_backlight_notify_power(priv);
 				break;
 			default:
-				ideapad_input_report(priv, vpc_bit);
+				pr_info("Unknown event: %lu\n", vpc_bit);
 			}
 		}
 	}