Patchwork [U-Boot] hawkboard: Fix SPL Nand driver misconfiguration

login
register
mail settings
Submitter Linu Cherian
Date July 27, 2012, 8:21 a.m.
Message ID <1343377313-30301-1-git-send-email-linucherian@gmail.com>
Download mbox | patch
Permalink /patch/173601/
State Accepted
Delegated to: Tom Rini
Headers show

Comments

Linu Cherian - July 27, 2012, 8:21 a.m.
Hawkboard was using the wrong nand_read_page version for SPL image.
As a side effect, the u-boot image loaded by the SPL from nand
was getting corrupted.

Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
algorithm for SPL.

Signed-off-by: Linu Cherian <linucherian@gmail.com>
---
 include/configs/hawkboard.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Sughosh Ganu - July 27, 2012, 9:46 a.m.
On Fri Jul 27, 2012 at 01:51:53PM +0530, Linu Cherian wrote:
> Hawkboard was using the wrong nand_read_page version for SPL image.
> As a side effect, the u-boot image loaded by the SPL from nand
> was getting corrupted.
> 
> Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
> algorithm for SPL.
> 
> Signed-off-by: Linu Cherian <linucherian@gmail.com>

Acked-by: Sughosh Ganu <urwithsughosh@gmail.com>

Tom, since this is a bug fix, can this go to the 2012.07 release.

-sughosh
Sughosh Ganu - July 30, 2012, 11:02 a.m.
hi Wolfgang,
On Fri Jul 27, 2012 at 03:16:15PM +0530, Sughosh Ganu wrote:
> On Fri Jul 27, 2012 at 01:51:53PM +0530, Linu Cherian wrote:
> > Hawkboard was using the wrong nand_read_page version for SPL image.
> > As a side effect, the u-boot image loaded by the SPL from nand
> > was getting corrupted.
> > 
> > Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
> > algorithm for SPL.
> > 
> > Signed-off-by: Linu Cherian <linucherian@gmail.com>
> 
> Acked-by: Sughosh Ganu <urwithsughosh@gmail.com>
> 
> Tom, since this is a bug fix, can this go to the 2012.07 release.

Did not get any response from Tom, so if it's not too late, can this
patch be applied to the master for the 2012.07 release. It is a
bugfix.

-sughosh
Tom Rini - July 30, 2012, 2:23 p.m.
On Fri, Jul 27, 2012 at 03:16:15PM +0530, Sughosh Ganu wrote:
> On Fri Jul 27, 2012 at 01:51:53PM +0530, Linu Cherian wrote:
> > Hawkboard was using the wrong nand_read_page version for SPL image.
> > As a side effect, the u-boot image loaded by the SPL from nand
> > was getting corrupted.
> > 
> > Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
> > algorithm for SPL.
> > 
> > Signed-off-by: Linu Cherian <linucherian@gmail.com>
> 
> Acked-by: Sughosh Ganu <urwithsughosh@gmail.com>
> 
> Tom, since this is a bug fix, can this go to the 2012.07 release.

Acked-by: Tom Rini <trini@ti.com>

Wolfgang, please take this for the release, thanks!
Wolfgang Denk - July 30, 2012, 6:22 p.m.
Dear Linu Cherian,

In message <1343377313-30301-1-git-send-email-linucherian@gmail.com> you wrote:
> Hawkboard was using the wrong nand_read_page version for SPL image.
> As a side effect, the u-boot image loaded by the SPL from nand
> was getting corrupted.
> 
> Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page
> algorithm for SPL.
> 
> Signed-off-by: Linu Cherian <linucherian@gmail.com>
> ---
>  include/configs/hawkboard.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/include/configs/hawkboard.h b/include/configs/hawkboard.h
index c6e8859..c6e9ce5 100644
--- a/include/configs/hawkboard.h
+++ b/include/configs/hawkboard.h
@@ -123,6 +123,7 @@ 
 #define CONFIG_SYS_NAND_USE_FLASH_BBT
 #define CONFIG_NAND_DAVINCI
 #define CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST
+#define CONFIG_SYS_NAND_HW_ECC_OOBFIRST /* SPL nand driver configuration */
 #define CFG_DAVINCI_STD_NAND_LAYOUT
 #define CONFIG_SYS_NAND_CS		3
 #define CONFIG_SYS_NAND_PAGE_2K