Patchwork [GIT,PULL] OMAP4 coupled CPUidle support for v3.6

login
register
mail settings
Submitter Kevin Hilman
Date July 26, 2012, 9:37 p.m.
Message ID <87394enqz8.fsf@ti.com>
Download mbox
Permalink /patch/173526/
State New
Headers show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.6/pm/coupled-cpuidle

Comments

Kevin Hilman - July 26, 2012, 9:37 p.m.
Hi Arnd, Olof,

I know it is late, but I'm really hoping this can still make it for
v3.6, so consider this a [GIT PLEA].  ;)

OMAP4 coupled CPUidle support has been well tested and was ready for the
v3.5 merge window, but there were some complaints from Linus in the pull
request from Len (unrelated to CPUidle) that caused the core support to
be left out of v3.5, so I didn't submit the OMAP stuff either.

Since then, there has been some confusion about maintainership of core
CPUidle code, including an additional cpuidle-next tree from Linaro
leading to confusion/delay about how/where to merge the OMAP support.

All of that is sorted out now, and Len has just sent his pull request[1]
to Linus including the core CPUidle changes to support coupled CPUidle,
so the path is now paved for the OMAP support.

Also, in mainline, CPUidle doesn't properly work on OMAP4 without
coupled states support, so there should be no concern about breaking
existing OMAP4 CPUidle support.

So, with all of that background and excuses,  could you please pull this
into one of your late branches (or maybe a new arm-soc/late/pm branch) ?

Thanks,

Kevin

[1] https://lkml.org/lkml/2012/7/26/6


The following changes since commit 28a33cbc24e4256c143dce96c7d93bf423229f92:

  Linux 3.5 (2012-07-21 13:58:29 -0700)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.6/pm/coupled-cpuidle

for you to fetch changes up to b93d70aeb8f3b5ed2d74643f5009239a55634e1d:

  ARM: OMAP4: CPUidle: Open broadcast clock-event device. (2012-07-25 16:06:08 -0700)

----------------------------------------------------------------
Kevin Hilman (1):
      ARM: OMAP4: CPUidle: add synchronization for coupled idle states

Santosh Shilimkar (3):
      ARM: OMAP: timer: allow gp timer clock-event to be used on both cpus
      ARM: OMAP4: CPUidle: Use coupled cpuidle states to implement SMP cpuidle.
      ARM: OMAP4: CPUidle: Open broadcast clock-event device.

 arch/arm/mach-omap2/Kconfig       |    1 +
 arch/arm/mach-omap2/cpuidle44xx.c |  141 +++++++++++++++++++++++++------------
 arch/arm/mach-omap2/timer.c       |    4 +-
 3 files changed, 101 insertions(+), 45 deletions(-)
Olof Johansson - July 27, 2012, 12:19 a.m.
Kevin,

On Thu, Jul 26, 2012 at 2:37 PM, Kevin Hilman <khilman@ti.com> wrote:
> Hi Arnd, Olof,
>
> I know it is late, but I'm really hoping this can still make it for
> v3.6, so consider this a [GIT PLEA].  ;)

New features submitted halfway through the merge window? Yeah, that's late.

I'll pull it in as late2/pm once the below is fixed, but I won't
promise we'll send it up.


> Kevin Hilman (1):
>       ARM: OMAP4: CPUidle: add synchronization for coupled idle states
>
> Santosh Shilimkar (3):
>       ARM: OMAP: timer: allow gp timer clock-event to be used on both cpus
>       ARM: OMAP4: CPUidle: Use coupled cpuidle states to implement SMP cpuidle.
>       ARM: OMAP4: CPUidle: Open broadcast clock-event device.

This looks odd, Colin was author to the first of the commits
attributed to Santosh.


-Olof
Santosh Shilimkar - July 27, 2012, 6:34 a.m.
On Fri, Jul 27, 2012 at 2:19 AM, Olof Johansson <olof@lixom.net> wrote:
> Kevin,
>
> On Thu, Jul 26, 2012 at 2:37 PM, Kevin Hilman <khilman@ti.com> wrote:
>> Hi Arnd, Olof,
>>
>> I know it is late, but I'm really hoping this can still make it for
>> v3.6, so consider this a [GIT PLEA].  ;)
>
> New features submitted halfway through the merge window? Yeah, that's late.
>
> I'll pull it in as late2/pm once the below is fixed, but I won't
> promise we'll send it up.
>
>
>> Kevin Hilman (1):
>>       ARM: OMAP4: CPUidle: add synchronization for coupled idle states
>>
>> Santosh Shilimkar (3):
>>       ARM: OMAP: timer: allow gp timer clock-event to be used on both cpus
>>       ARM: OMAP4: CPUidle: Use coupled cpuidle states to implement SMP cpuidle.
>>       ARM: OMAP4: CPUidle: Open broadcast clock-event device.
>
> This looks odd, Colin was author to the first of the commits
> attributed to Santosh.
>
Not sure what you mean. These patches are written by me. Kevin, Collin helped
in review. If you are referring to the {ARM: OMAP: timer: allow gp
timer clock-event to be
used on both cpus} which does have SOB from me and Colin. The very first version
of this version I picked was from product tree in which it was
commited on Coiln's name.
Later I updated that forf the multi-omap and the new timer code and
hence the update
in Author.

Hope this clear.

Regards
Santosh
Colin Cross - July 27, 2012, 6:44 a.m.
On Thu, Jul 26, 2012 at 11:34 PM, Shilimkar, Santosh
<santosh.shilimkar@ti.com> wrote:
> On Fri, Jul 27, 2012 at 2:19 AM, Olof Johansson <olof@lixom.net> wrote:
>> Kevin,
>>
>> On Thu, Jul 26, 2012 at 2:37 PM, Kevin Hilman <khilman@ti.com> wrote:
>>> Hi Arnd, Olof,
>>>
>>> I know it is late, but I'm really hoping this can still make it for
>>> v3.6, so consider this a [GIT PLEA].  ;)
>>
>> New features submitted halfway through the merge window? Yeah, that's late.
>>
>> I'll pull it in as late2/pm once the below is fixed, but I won't
>> promise we'll send it up.
>>
>>
>>> Kevin Hilman (1):
>>>       ARM: OMAP4: CPUidle: add synchronization for coupled idle states
>>>
>>> Santosh Shilimkar (3):
>>>       ARM: OMAP: timer: allow gp timer clock-event to be used on both cpus
>>>       ARM: OMAP4: CPUidle: Use coupled cpuidle states to implement SMP cpuidle.
>>>       ARM: OMAP4: CPUidle: Open broadcast clock-event device.
>>
>> This looks odd, Colin was author to the first of the commits
>> attributed to Santosh.
>>
> Not sure what you mean. These patches are written by me. Kevin, Collin helped
> in review. If you are referring to the {ARM: OMAP: timer: allow gp
> timer clock-event to be
> used on both cpus} which does have SOB from me and Colin. The very first version
> of this version I picked was from product tree in which it was
> commited on Coiln's name.
> Later I updated that forf the multi-omap and the new timer code and
> hence the update
> in Author.

I have no problem with the authorship on these two patches.
Olof Johansson - July 27, 2012, 8:22 p.m.
On Thu, Jul 26, 2012 at 11:44 PM, Colin Cross <ccross@android.com> wrote:
> On Thu, Jul 26, 2012 at 11:34 PM, Shilimkar, Santosh
> <santosh.shilimkar@ti.com> wrote:
>> On Fri, Jul 27, 2012 at 2:19 AM, Olof Johansson <olof@lixom.net> wrote:
>>> Kevin,
>>>
>>> On Thu, Jul 26, 2012 at 2:37 PM, Kevin Hilman <khilman@ti.com> wrote:
>>>> Hi Arnd, Olof,
>>>>
>>>> I know it is late, but I'm really hoping this can still make it for
>>>> v3.6, so consider this a [GIT PLEA].  ;)
>>>
>>> New features submitted halfway through the merge window? Yeah, that's late.
>>>
>>> I'll pull it in as late2/pm once the below is fixed, but I won't
>>> promise we'll send it up.
>>>
>>>
>>>> Kevin Hilman (1):
>>>>       ARM: OMAP4: CPUidle: add synchronization for coupled idle states
>>>>
>>>> Santosh Shilimkar (3):
>>>>       ARM: OMAP: timer: allow gp timer clock-event to be used on both cpus
>>>>       ARM: OMAP4: CPUidle: Use coupled cpuidle states to implement SMP cpuidle.
>>>>       ARM: OMAP4: CPUidle: Open broadcast clock-event device.
>>>
>>> This looks odd, Colin was author to the first of the commits
>>> attributed to Santosh.
>>>
>> Not sure what you mean. These patches are written by me. Kevin, Collin helped
>> in review. If you are referring to the {ARM: OMAP: timer: allow gp
>> timer clock-event to be
>> used on both cpus} which does have SOB from me and Colin. The very first version
>> of this version I picked was from product tree in which it was
>> commited on Coiln's name.
>> Later I updated that forf the multi-omap and the new timer code and
>> hence the update
>> in Author.
>
> I have no problem with the authorship on these two patches.

Santosh, Colin,

Ok, fair enough -- I just want to make sure attribution happens
appropriately, and it's a red flag when there's a S-o-b by someone not
at your company before yours without explanation.



-Olof
Santosh Shilimkar - July 27, 2012, 9:36 p.m.
On Fri, Jul 27, 2012 at 10:22 PM, Olof Johansson <olof@lixom.net> wrote:
> On Thu, Jul 26, 2012 at 11:44 PM, Colin Cross <ccross@android.com> wrote:
>> On Thu, Jul 26, 2012 at 11:34 PM, Shilimkar, Santosh
>> <santosh.shilimkar@ti.com> wrote:
>>> On Fri, Jul 27, 2012 at 2:19 AM, Olof Johansson <olof@lixom.net> wrote:
>>>> Kevin,
>>>>
>>>> On Thu, Jul 26, 2012 at 2:37 PM, Kevin Hilman <khilman@ti.com> wrote:
>>>>> Hi Arnd, Olof,
>>>>>
>>>>> I know it is late, but I'm really hoping this can still make it for
>>>>> v3.6, so consider this a [GIT PLEA].  ;)
>>>>
>>>> New features submitted halfway through the merge window? Yeah, that's late.
>>>>
>>>> I'll pull it in as late2/pm once the below is fixed, but I won't
>>>> promise we'll send it up.
>>>>
>>>>
>>>>> Kevin Hilman (1):
>>>>>       ARM: OMAP4: CPUidle: add synchronization for coupled idle states
>>>>>
>>>>> Santosh Shilimkar (3):
>>>>>       ARM: OMAP: timer: allow gp timer clock-event to be used on both cpus
>>>>>       ARM: OMAP4: CPUidle: Use coupled cpuidle states to implement SMP cpuidle.
>>>>>       ARM: OMAP4: CPUidle: Open broadcast clock-event device.
>>>>
>>>> This looks odd, Colin was author to the first of the commits
>>>> attributed to Santosh.
>>>>
>>> Not sure what you mean. These patches are written by me. Kevin, Collin helped
>>> in review. If you are referring to the {ARM: OMAP: timer: allow gp
>>> timer clock-event to be
>>> used on both cpus} which does have SOB from me and Colin. The very first version
>>> of this version I picked was from product tree in which it was
>>> commited on Coiln's name.
>>> Later I updated that forf the multi-omap and the new timer code and
>>> hence the update
>>> in Author.
>>
>> I have no problem with the authorship on these two patches.
>
> Santosh, Colin,
>
> Ok, fair enough -- I just want to make sure attribution happens
> appropriately, and it's a red flag when there's a S-o-b by someone not
> at your company before yours without explanation.
>
Sure. No problem with that.

Regards
Santosh
Kevin Hilman - July 28, 2012, 12:33 a.m.
Olof Johansson <olof@lixom.net> writes:

> On Thu, Jul 26, 2012 at 11:44 PM, Colin Cross <ccross@android.com> wrote:
>> On Thu, Jul 26, 2012 at 11:34 PM, Shilimkar, Santosh
>> <santosh.shilimkar@ti.com> wrote:
>>> On Fri, Jul 27, 2012 at 2:19 AM, Olof Johansson <olof@lixom.net> wrote:
>>>> Kevin,
>>>>
>>>> On Thu, Jul 26, 2012 at 2:37 PM, Kevin Hilman <khilman@ti.com> wrote:
>>>>> Hi Arnd, Olof,
>>>>>
>>>>> I know it is late, but I'm really hoping this can still make it for
>>>>> v3.6, so consider this a [GIT PLEA].  ;)
>>>>
>>>> New features submitted halfway through the merge window? Yeah, that's late.
>>>>
>>>> I'll pull it in as late2/pm once the below is fixed, but I won't
>>>> promise we'll send it up.
>>>>
>>>>
>>>>> Kevin Hilman (1):
>>>>>       ARM: OMAP4: CPUidle: add synchronization for coupled idle states
>>>>>
>>>>> Santosh Shilimkar (3):
>>>>>       ARM: OMAP: timer: allow gp timer clock-event to be used on both cpus
>>>>>       ARM: OMAP4: CPUidle: Use coupled cpuidle states to implement SMP cpuidle.
>>>>>       ARM: OMAP4: CPUidle: Open broadcast clock-event device.
>>>>
>>>> This looks odd, Colin was author to the first of the commits
>>>> attributed to Santosh.
>>>>
>>> Not sure what you mean. These patches are written by me. Kevin, Collin helped
>>> in review. If you are referring to the {ARM: OMAP: timer: allow gp
>>> timer clock-event to be
>>> used on both cpus} which does have SOB from me and Colin. The very first version
>>> of this version I picked was from product tree in which it was
>>> commited on Coiln's name.
>>> Later I updated that forf the multi-omap and the new timer code and
>>> hence the update
>>> in Author.
>>
>> I have no problem with the authorship on these two patches.
>
> Santosh, Colin,
>
> Ok, fair enough -- I just want to make sure attribution happens
> appropriately, and it's a red flag when there's a S-o-b by someone not
> at your company before yours without explanation.

Thanks Olof for considering this very late branch.

Kevin