From patchwork Thu Jan 8 12:19:49 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Milton Miller X-Patchwork-Id: 17347 X-Patchwork-Delegate: benh@kernel.crashing.org Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from ozlabs.org (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 9E822DE8B3 for ; Thu, 8 Jan 2009 23:31:07 +1100 (EST) X-Original-To: linuxppc-dev@ozlabs.org Delivered-To: linuxppc-dev@ozlabs.org Received: from mercury.realtime.net (mercury.realtime.net [205.238.132.86]) by ozlabs.org (Postfix) with ESMTP id 46D19DE90F for ; Thu, 8 Jan 2009 23:19:52 +1100 (EST) Received: from miltonm.aip.bga.com (01-056.251.popsite.net [205.232.218.56]) by realtime.net (Realtime Communications Advanced E-Mail Services V9.2) with ESMTP id 230063877-1817707 for multiple; Thu, 08 Jan 2009 06:19:49 -0600 To: Benjamin Herrenschmidt From: Milton Miller Subject: [PATCH 2/4] powerpc: remove write only variable Date: Thu, 08 Jan 2009 06:19:49 -0600 X-Originating-IP: 205.232.218.56 Message-ID: <1231417189_141720@mercury.realtime.net> Cc: linuxppc-dev@ozlabs.org X-BeenThere: linuxppc-dev@ozlabs.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Errors-To: linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@ozlabs.org Since we never hotplug add an isa bus, we never need to set primary. Delete this write-only variable. Signed-off-by: Milton Miller --- The reference to primary was removed in during a code move 92eb4602 (v2.6.16) when dlpar for p5ioc was tested. Index: work.git/arch/powerpc/platforms/pseries/pci_dlpar.c =================================================================== --- work.git.orig/arch/powerpc/platforms/pseries/pci_dlpar.c 2009-01-05 04:38:15.000000000 -0600 +++ work.git/arch/powerpc/platforms/pseries/pci_dlpar.c 2009-01-05 04:38:48.000000000 -0600 @@ -137,11 +137,9 @@ EXPORT_SYMBOL_GPL(pcibios_add_pci_device struct pci_controller * __devinit init_phb_dynamic(struct device_node *dn) { struct pci_controller *phb; - int primary; pr_debug("PCI: Initializing new hotplug PHB %s\n", dn->full_name); - primary = list_empty(&hose_list); phb = pcibios_alloc_controller(dn); if (!phb) return NULL;