From patchwork Thu Jul 26 02:29:30 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [v2,3/3] ARM: imx_v6_v7_defconfig: Select MXS_DMA Date: Wed, 25 Jul 2012 16:29:30 -0000 From: Dong Aisheng X-Patchwork-Id: 173319 Message-Id: <20120726022930.GB3396@shlinux2.ap.freescale.net> To: Huang Shijie Cc: Fabio Estevam , Artem.Bityutskiy@linux.intel.com, b32955@freescale.com, linux-mtd@lists.infradead.org, kernel@pengutronix.de, shawn.guo@linaro.org, Fabio Estevam , dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org On Thu, Jul 26, 2012 at 10:24:41AM +0800, Huang Shijie wrote: > On Wed, Jul 25, 2012 at 11:23 PM, Fabio Estevam wrote: > > On Wed, Jul 25, 2012 at 12:05 PM, Huang Shijie wrote: > > > >> Is this patch needed? The mxs-dma only has one user, the gpmi-nand in mx6q. > >> this patch makes the kernel built-in the mxs-dma, even the gpmi-nand > >> is not enabled. > > > > Well, as the driver currently stands: yes, it is needed. > > > > Without CONFIG_MXS_DMA, the GPMI driver cannot even be built. > But you have added "depend on MXS_DMA". So If you do not select the > mxs-dma, you can not see the > gpmi-nand. > that's why i think this patch is not needed. > How about using 'select MXS_DMA'? still compiled even GPMI_NAND is not selected. Regards Dong Aisheng diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig index 31bb7e5..e7c3dcf 100644 --- a/drivers/mtd/nand/Kconfig +++ b/drivers/mtd/nand/Kconfig @@ -481,6 +481,7 @@ config MTD_NAND_NANDSIM config MTD_NAND_GPMI_NAND bool "GPMI NAND Flash Controller driver" depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q) + select MXS_DMA help Then we do not need this patch and does not have the issue that MXS_DMA is