Patchwork [06/11] qerror: QERR_AMBIGUOUS_PATH: drop %(object) from human msg

login
register
mail settings
Submitter Luiz Capitulino
Date July 25, 2012, 4:54 p.m.
Message ID <1343235256-26310-7-git-send-email-lcapitulino@redhat.com>
Download mbox | patch
Permalink /patch/173225/
State New
Headers show

Comments

Luiz Capitulino - July 25, 2012, 4:54 p.m.
Actually, renames it to 'object'. This must be what the original author
meant to write, as there's no 'object' in the error's data member.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 qerror.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Markus Armbruster - July 26, 2012, 11:12 a.m.
Luiz Capitulino <lcapitulino@redhat.com> writes:

> Actually, renames it to 'object'. This must be what the original author
> meant to write, as there's no 'object' in the error's data member.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> ---
>  qerror.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qerror.c b/qerror.c
> index 3d8ba2a..01d2493 100644
> --- a/qerror.c
> +++ b/qerror.c
> @@ -49,7 +49,7 @@ static const QErrorStringTable qerror_table[] = {
>      },
>      {
>          .error_fmt = QERR_AMBIGUOUS_PATH,
> -        .desc      = "Path '%(path)' does not uniquely identify a %(object)"
> +        .desc      = "Path '%(path)' does not uniquely identify a object"
>      },
>      {
>          .error_fmt = QERR_BAD_BUS_FOR_DEVICE,

"an object", please.
Luiz Capitulino - July 26, 2012, 2:15 p.m.
On Thu, 26 Jul 2012 13:12:11 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > Actually, renames it to 'object'. This must be what the original author
> > meant to write, as there's no 'object' in the error's data member.
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> > ---
> >  qerror.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qerror.c b/qerror.c
> > index 3d8ba2a..01d2493 100644
> > --- a/qerror.c
> > +++ b/qerror.c
> > @@ -49,7 +49,7 @@ static const QErrorStringTable qerror_table[] = {
> >      },
> >      {
> >          .error_fmt = QERR_AMBIGUOUS_PATH,
> > -        .desc      = "Path '%(path)' does not uniquely identify a %(object)"
> > +        .desc      = "Path '%(path)' does not uniquely identify a object"
> >      },
> >      {
> >          .error_fmt = QERR_BAD_BUS_FOR_DEVICE,
> 
> "an object", please.

Fixed for v3, thanks.

Patch

diff --git a/qerror.c b/qerror.c
index 3d8ba2a..01d2493 100644
--- a/qerror.c
+++ b/qerror.c
@@ -49,7 +49,7 @@  static const QErrorStringTable qerror_table[] = {
     },
     {
         .error_fmt = QERR_AMBIGUOUS_PATH,
-        .desc      = "Path '%(path)' does not uniquely identify a %(object)"
+        .desc      = "Path '%(path)' does not uniquely identify a object"
     },
     {
         .error_fmt = QERR_BAD_BUS_FOR_DEVICE,