| Message ID | d16976055462214af276d7242faa2bc6e621fd44.1343191280.git.afzal@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
Hello. On 25-07-2012 10:12, Afzal Mohammed wrote: > Add AM33xx rtc node. > Signed-off-by: Afzal Mohammed <afzal@ti.com> > --- > v2: > Use compatible as ti,da830-rtc instead of ti,am1808-rtc > arch/arm/boot/dts/am33xx.dtsi | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi > index bd0cff3..e1ed72d 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -159,5 +159,10 @@ > compatible = "ti,omap3-wdt"; > ti,hwmods = "wd_timer2"; > }; > + > + rtc@44e3e000 { Address postfix in the node name without "reg" property? > + compatible = "ti,da830-rtc"; > + ti,hwmods = "rtc"; > + }; WBR, Sergei
Hi Sergei, On Wed, Jul 25, 2012 at 16:50:56, Sergei Shtylyov wrote: > > + rtc@44e3e000 { > > Address postfix in the node name without "reg" property? As per [1], "The unit-address is included if the node describes a device with an address". Here even though reg property is not present, as via hwmod (see below) it is getting address, isn't it better to have it > > > + compatible = "ti,da830-rtc"; > > + ti,hwmods = "rtc"; Regards Afzal [1] http://devicetree.org/Device_Tree_Usage
Hello. On 07/25/2012 06:09 PM, Mohammed, Afzal wrote: >>> + rtc@44e3e000 { >> Address postfix in the node name without "reg" property? > As per [1], "The unit-address is included if the node describes > a device with an address". Which in this case it doesn't. > Here even though reg property is not present, as via hwmod > (see below) it is getting address, isn't it better to have it I think not. >>> + compatible = "ti,da830-rtc"; >>> + ti,hwmods = "rtc"; WBR, Sergei
Hi Sergei, On Wed, Jul 25, 2012 at 22:29:24, Sergei Shtylyov wrote: > >>> + rtc@44e3e000 { > > >> Address postfix in the node name without "reg" property? > > > As per [1], "The unit-address is included if the node describes > > a device with an address". > > Which in this case it doesn't. > > > Here even though reg property is not present, as via hwmod > > (see below) it is getting address, isn't it better to have it > > I think not. Ok, I will remove it > >>> + compatible = "ti,da830-rtc"; > >>> + ti,hwmods = "rtc"; Regards Afzal
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi index bd0cff3..e1ed72d 100644 --- a/arch/arm/boot/dts/am33xx.dtsi +++ b/arch/arm/boot/dts/am33xx.dtsi @@ -159,5 +159,10 @@ compatible = "ti,omap3-wdt"; ti,hwmods = "wd_timer2"; }; + + rtc@44e3e000 { + compatible = "ti,da830-rtc"; + ti,hwmods = "rtc"; + }; }; };
Add AM33xx rtc node. Signed-off-by: Afzal Mohammed <afzal@ti.com> --- v2: Use compatible as ti,da830-rtc instead of ti,am1808-rtc arch/arm/boot/dts/am33xx.dtsi | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)