Patchwork [v2,2/2] get_fw_dev_path() impls should allocate memory with glib functions

login
register
mail settings
Submitter Laszlo Ersek
Date July 25, 2012, 12:19 a.m.
Message ID <1343175595-7944-3-git-send-email-lersek@redhat.com>
Download mbox | patch
Permalink /patch/173086/
State New
Headers show

Comments

Laszlo Ersek - July 25, 2012, 12:19 a.m.
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
---
 hw/ide/qdev.c |    2 +-
 hw/isa-bus.c  |    2 +-
 hw/pci.c      |    2 +-
 hw/scsi-bus.c |    2 +-
 hw/sysbus.c   |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

Patch

diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c
index 22e58df..4f15070 100644
--- a/hw/ide/qdev.c
+++ b/hw/ide/qdev.c
@@ -60,7 +60,7 @@  static char *idebus_get_fw_dev_path(DeviceState *dev)
     snprintf(path, sizeof(path), "%s@%d", qdev_fw_name(dev),
              ((IDEBus*)dev->parent_bus)->bus_id);
 
-    return strdup(path);
+    return g_strdup(path);
 }
 
 static int ide_qdev_init(DeviceState *qdev)
diff --git a/hw/isa-bus.c b/hw/isa-bus.c
index f9b2373..47c93d3 100644
--- a/hw/isa-bus.c
+++ b/hw/isa-bus.c
@@ -236,7 +236,7 @@  static char *isabus_get_fw_dev_path(DeviceState *dev)
         snprintf(path + off, sizeof(path) - off, "@%04x", d->ioport_id);
     }
 
-    return strdup(path);
+    return g_strdup(path);
 }
 
 MemoryRegion *isa_address_space(ISADevice *dev)
diff --git a/hw/pci.c b/hw/pci.c
index 99a4304..ef8996d 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1920,7 +1920,7 @@  static char *pcibus_get_fw_dev_path(DeviceState *dev)
                    PCI_SLOT(d->devfn));
     if (PCI_FUNC(d->devfn))
         snprintf(path + off, sizeof(path) + off, ",%x", PCI_FUNC(d->devfn));
-    return strdup(path);
+    return g_strdup(path);
 }
 
 static char *pcibus_get_dev_path(DeviceState *dev)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index dc74063..4544d0b 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -1547,7 +1547,7 @@  static char *scsibus_get_fw_dev_path(DeviceState *dev)
     snprintf(path, sizeof(path), "channel@%x/%s@%x,%x", d->channel,
              qdev_fw_name(dev), d->id, d->lun);
 
-    return strdup(path);
+    return g_strdup(path);
 }
 
 SCSIDevice *scsi_device_find(SCSIBus *bus, int channel, int id, int lun)
diff --git a/hw/sysbus.c b/hw/sysbus.c
index 9d8b1ea..c173840 100644
--- a/hw/sysbus.c
+++ b/hw/sysbus.c
@@ -211,7 +211,7 @@  static char *sysbus_get_fw_dev_path(DeviceState *dev)
         snprintf(path + off, sizeof(path) - off, "@i%04x", s->pio[0]);
     }
 
-    return strdup(path);
+    return g_strdup(path);
 }
 
 void sysbus_add_memory(SysBusDevice *dev, target_phys_addr_t addr,