Patchwork [RFC,3/9] virtio-pci: check that event notification worked

login
register
mail settings
Submitter Nicholas A. Bellinger
Date July 24, 2012, 10:34 p.m.
Message ID <1343169246-17636-4-git-send-email-nab@linux-iscsi.org>
Download mbox | patch
Permalink /patch/173071/
State New
Headers show

Comments

Nicholas A. Bellinger - July 24, 2012, 10:34 p.m.
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

For sanity assert that event notification succeeds.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
---
 hw/virtio-pci.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

Patch

diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c
index 538eef4..0f0f766 100644
--- a/hw/virtio-pci.c
+++ b/hw/virtio-pci.c
@@ -261,8 +261,11 @@  static void virtio_pci_queue_notify(VirtIOPCIProxy *proxy, uint32_t n)
     vq = virtio_get_queue(proxy->vdev, n);
     notifier = virtio_queue_get_host_notifier(vq);
     if (event_notifier_valid(notifier)) {
+        int r;
+
         printf("notifying vq %u host notifier from userspace\n", n);
-        event_notifier_notify(notifier);
+        r = event_notifier_notify(notifier);
+        assert(r == 0);
     } else {
         virtio_queue_notify_vq(vq);
     }