Patchwork [06/27] ram: introduce migration_bitmap_set_dirty()

login
register
mail settings
Submitter Juan Quintela
Date July 24, 2012, 6:36 p.m.
Message ID <1343155012-26316-7-git-send-email-quintela@redhat.com>
Download mbox | patch
Permalink /patch/173017/
State New
Headers show

Comments

Juan Quintela - July 24, 2012, 6:36 p.m.
It just marks a region of memory as dirty.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 arch_init.c |   20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

Patch

diff --git a/arch_init.c b/arch_init.c
index 5a97710..b47bf05 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -342,6 +342,18 @@  static RAMBlock *last_block;
 static ram_addr_t last_offset;
 static uint32_t last_version;

+static inline void migration_bitmap_set_dirty(MemoryRegion *mr, int length)
+{
+    ram_addr_t addr;
+
+    for (addr = 0; addr < length; addr += TARGET_PAGE_SIZE) {
+        if (!memory_region_get_dirty(mr, addr, TARGET_PAGE_SIZE,
+                                     DIRTY_MEMORY_MIGRATION)) {
+            memory_region_set_dirty(mr, addr, TARGET_PAGE_SIZE);
+        }
+    }
+}
+
 /*
  * ram_save_block: Writes a page of memory to the stream f
  *
@@ -504,7 +516,6 @@  static void reset_ram_globals(void)

 static int ram_save_setup(QEMUFile *f, void *opaque)
 {
-    ram_addr_t addr;
     RAMBlock *block;

     qemu_mutex_lock_ramlist();
@@ -526,12 +537,7 @@  static int ram_save_setup(QEMUFile *f, void *opaque)
     }

     QLIST_FOREACH(block, &ram_list.blocks, next) {
-        for (addr = 0; addr < block->length; addr += TARGET_PAGE_SIZE) {
-            if (!memory_region_get_dirty(block->mr, addr, TARGET_PAGE_SIZE,
-                                         DIRTY_MEMORY_MIGRATION)) {
-                memory_region_set_dirty(block->mr, addr, TARGET_PAGE_SIZE);
-            }
-        }
+        migration_bitmap_set_dirty(block->mr, block->length);
     }

     memory_global_dirty_log_start();