From patchwork Tue Jul 24 16:57:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Janis Johnson X-Patchwork-Id: 172973 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 8C52D2C008F for ; Wed, 25 Jul 2012 02:57:40 +1000 (EST) Comment: DKIM? See http://www.dkim.org DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gcc.gnu.org; s=default; x=1343753861; h=Comment: DomainKey-Signature:Received:Received:Received:Received:Received: Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version: To:Subject:Content-Type:Mailing-List:Precedence:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:Sender: Delivered-To; bh=uZ33DdO89cSj20u4ShuhuagM8R0=; b=MI96AKsjUn1XuQp rr4HbWyMxyMljVj2oHatYV709JHYLNMhpTfvAKeURJ88gpTGfqNMyUP6Mqa1n6oB j9uZwtglnA9ODaWcRKhGTSpNMPNJRKACKVaQEbF1geGqxkO7O2xJJe9r7M+DP+5t Lm2KNQxyhNtpUlCQ2B3xfXk0ZyxQ= Comment: DomainKeys? See http://antispam.yahoo.com/domainkeys DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=gcc.gnu.org; h=Received:Received:X-SWARE-Spam-Status:X-Spam-Check-By:Received:Received:Received:Received:Message-ID:Date:From:Reply-To:User-Agent:MIME-Version:To:Subject:Content-Type:Mailing-List:Precedence:List-Id:List-Unsubscribe:List-Archive:List-Post:List-Help:Sender:Delivered-To; b=rDzmQ97+t6pQkm/rgaBB5hw8VQQvaGrsn4Od4edJd02k9ghXA/D9mfLOPbFmYQ SavoKt7I7qiJ9G/9NbCSVaMsH42fl6aiGHBH3H1HEEWCj0MJ8qlnbFudSvlSrngX rxyRlm6nCTZObPo4UEq77xwAEx6hyHSly8g4cef7bbAJI=; Received: (qmail 9103 invoked by alias); 24 Jul 2012 16:57:34 -0000 Received: (qmail 9095 invoked by uid 22791); 24 Jul 2012 16:57:32 -0000 X-SWARE-Spam-Status: No, hits=-3.6 required=5.0 tests=AWL, BAYES_00, KHOP_RCVD_UNTRUST, RCVD_IN_HOSTKARMA_W, RCVD_IN_HOSTKARMA_WL, TW_GC, TW_SG X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jul 2012 16:57:18 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1StiQ8-0006yV-Pl from Janis_Johnson@mentor.com for gcc-patches@gcc.gnu.org; Tue, 24 Jul 2012 09:57:16 -0700 Received: from SVR-ORW-FEM-04.mgc.mentorg.com ([147.34.97.41]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Tue, 24 Jul 2012 09:57:16 -0700 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.1.289.1; Tue, 24 Jul 2012 09:57:15 -0700 Message-ID: <500ED404.7020200@mentor.com> Date: Tue, 24 Jul 2012 09:57:40 -0700 From: Janis Johnson Reply-To: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.28) Gecko/20120313 Thunderbird/3.1.20 MIME-Version: 1.0 To: "gcc-patches@gcc.gnu.org" Subject: [testsuite] don't ignore errors for dg-error and friends Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org This patch prevents errors in dg-error, dg-warning, and dg-message from being silently ignored by GCC's overrides for those procedures. It's been tested on i686-pc-linux-gnu for the languages that use the overrides (c,c++,fortran,objc,obj-c++). I scanned through target-specific tests and didn't see anything problematic, but it's possible I missed something and errors will be reported. Checked in on mainline, and I plan to add it to 4.7 soon. Janis 2012-07-24 Janis Johnson * lib/gcc-dg.exp (process-message): Don't ignore errors. Index: testsuite/lib/gcc-dg.exp =================================================================== --- testsuite/lib/gcc-dg.exp (revision 189790) +++ testsuite/lib/gcc-dg.exp (working copy) @@ -739,7 +739,7 @@ # Process the dg- directive, including adding the regular expression # to the new message entry in dg-messages. set msgcnt [llength ${dg-messages}] - catch { eval $msgproc $dgargs } + eval $msgproc $dgargs # If the target expression wasn't satisfied there is no new message. if { [llength ${dg-messages}] == $msgcnt } {