Patchwork [2/2] mtd: nand: Select MXS_DMA for MTD_NAND_GPMI_NAND

login
register
mail settings
Submitter Fabio Estevam
Date July 24, 2012, 4:15 p.m.
Message ID <1343146515-18578-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/172919/
State New
Headers show

Comments

Fabio Estevam - July 24, 2012, 4:15 p.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

MTD_NAND_GPMI_NAND driver needs MXS_DMA to be selected, otherwise the following error happens
for imx_v6_v7_defconfig:

drivers/built-in.o: In function `gpmi_dma_filter':
clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
make: *** [vmlinux] Error 1

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 drivers/mtd/nand/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Huang Shijie - July 25, 2012, 5:58 a.m.
于 2012年07月25日 00:15, Fabio Estevam 写道:
> From: Fabio Estevam<fabio.estevam@freescale.com>
>
> MTD_NAND_GPMI_NAND driver needs MXS_DMA to be selected, otherwise the following error happens
> for imx_v6_v7_defconfig:
>
> drivers/built-in.o: In function `gpmi_dma_filter':
> clk-fixed-factor.c:(.text+0xb124c): undefined reference to `mxs_dma_is_apbh'
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Fabio Estevam<fabio.estevam@freescale.com>
> ---
>   drivers/mtd/nand/Kconfig |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index b40e172..2062ee9 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -463,6 +463,7 @@ config MTD_NAND_NANDSIM
>   config MTD_NAND_GPMI_NAND
>           bool "GPMI NAND Flash Controller driver"
>           depends on MTD_NAND&&  (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q)
> +	select MXS_DMA
>           help
>   	 Enables NAND Flash support for IMX23/28/6.
>   	 The GPMI controller is very powerful, with the help of BCH
thanks, but please see this thread.

http://comments.gmane.org/gmane.linux.ports.arm.kernel/146232

Huang Shijie
Fabio Estevam - July 25, 2012, 10:32 a.m.
On Wed, Jul 25, 2012 at 2:58 AM, Huang Shijie <b32955@freescale.com> wrote:

> thanks, but please see this thread.
>
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/146232

Ok, but what is the conclusion on this then? It has been 8 months
since that thread started and the problem is still present.
Huang Shijie - July 25, 2012, 10:38 a.m.
于 2012年07月25日 18:32, Fabio Estevam 写道:
> On Wed, Jul 25, 2012 at 2:58 AM, Huang Shijie<b32955@freescale.com>  wrote:
>
>> thanks, but please see this thread.
>>
>> http://comments.gmane.org/gmane.linux.ports.arm.kernel/146232
> Ok, but what is the conclusion on this then? It has been 8 months
> since that thread started and the problem is still present.
>
If we want to fix it, we can add the "depend on MXS-DMA" for gpmi nand.

Huang Shijie
Fabio Estevam - July 25, 2012, 10:38 a.m.
On Wed, Jul 25, 2012 at 7:38 AM, Huang Shijie <b32955@freescale.com> wrote:

> If we want to fix it, we can add the "depend on MXS-DMA" for gpmi nand.

Ok, I will submit a fix using "depends" then.

Thanks,

Fabio Estevam

Patch

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index b40e172..2062ee9 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -463,6 +463,7 @@  config MTD_NAND_NANDSIM
 config MTD_NAND_GPMI_NAND
         bool "GPMI NAND Flash Controller driver"
         depends on MTD_NAND && (SOC_IMX23 || SOC_IMX28 || SOC_IMX6Q)
+	select MXS_DMA
         help
 	 Enables NAND Flash support for IMX23/28/6.
 	 The GPMI controller is very powerful, with the help of BCH