From patchwork Tue Jul 24 12:34:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Dawson X-Patchwork-Id: 172869 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from silver.osuosl.org (silver.osuosl.org [140.211.166.136]) by ozlabs.org (Postfix) with ESMTP id 2D9EF2C007D for ; Tue, 24 Jul 2012 22:34:46 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id 029D6322A9; Tue, 24 Jul 2012 12:34:44 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id brKsVD5P-9dN; Tue, 24 Jul 2012 12:34:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id EDB4F3227D; Tue, 24 Jul 2012 12:34:40 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id CE5B68F798 for ; Tue, 24 Jul 2012 12:34:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id C2D908C3F1 for ; Tue, 24 Jul 2012 12:34:39 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GZCWLrOPol7k for ; Tue, 24 Jul 2012 12:34:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-bk0-f43.google.com (mail-bk0-f43.google.com [209.85.214.43]) by whitealder.osuosl.org (Postfix) with ESMTPS id 3915689C22 for ; Tue, 24 Jul 2012 12:34:38 +0000 (UTC) Received: by bkty15 with SMTP id y15so10160463bkt.16 for ; Tue, 24 Jul 2012 05:34:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:x-mailer; bh=/H6bUVVnf1L2U77xjd1vNOiqIoDKh8frplDkp0VFuy4=; b=BCtTQBpE3ILNpRmkJ/nETvwIF95jicb3OtbbvNF+vSK8Hfs1Aunaj1+RBTFNLWsm6w jiNeriiVkKglR7Dba14k05P71zpS05owYkNvFzxGiQJfeeb6G7bab70qFTTRdAXabSdf WES/5K4b6xfbiWjEhwozcafPuwlVHVp8DqeSMmA47iV/R/a3ONcAPVUiNtYX5IUskXxO irYgPWj6puQY6GFP+Fg6DpZMFjsk8alXl/5ysOe/KKbSroVzgrzIPIJlKmruMMtY4DZc 4RESzBXGenCfmoo6pht8pDQNs3jqWGAfl8xKZ3CZXhunG+9i4zFCjwp31sa/8LxOcci4 dAxA== Received: by 10.204.154.66 with SMTP id n2mr9858812bkw.138.1343133276067; Tue, 24 Jul 2012 05:34:36 -0700 (PDT) Received: from percy.train.local ([213.170.149.177]) by mx.google.com with ESMTPS id hs2sm10663733bkc.1.2012.07.24.05.34.33 (version=SSLv3 cipher=OTHER); Tue, 24 Jul 2012 05:34:35 -0700 (PDT) From: spdawson@gmail.com To: buildroot@busybox.net Date: Tue, 24 Jul 2012 13:34:32 +0100 Message-Id: <1343133272-3099-1-git-send-email-spdawson@gmail.com> X-Mailer: git-send-email 1.7.9.5 Subject: [Buildroot] [PATCH v2] gpsd: disallow profiling support with uClibc toolchain X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net From: Simon Dawson The following problem was reported by Thomas Petazzoni. If BR2_PACKAGE_GPSD_PROFILING is enabled with a uClibc-based toolchain, then gpsd fails to build. See the following for details. http://autobuild.buildroot.org/results/be707893f4bf0e7e964d183e4a655c5bb72d1889/build-end.log http://autobuild.buildroot.org/results/be707893f4bf0e7e964d183e4a655c5bb72d1889/defconfig. The issue is that uClibc lacks the necessary infrastructure to support profiling. This patch disallows selection of the gpsd profiling feature when a uClibc-based toolchain is selected. Signed-off-by: Simon Dawson --- v2: Correct logic to handle all uClibc-based toolchains. package/gpsd/Config.in | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/gpsd/Config.in b/package/gpsd/Config.in index 18e21e5..db6bec2 100644 --- a/package/gpsd/Config.in +++ b/package/gpsd/Config.in @@ -31,6 +31,10 @@ config BR2_PACKAGE_GPSD_OLDSTYLE config BR2_PACKAGE_GPSD_PROFILING bool "profiling support" + depends on !BR2_TOOLCHAIN_BUILDROOT && !BR2_TOOLCHAIN_CTNG_uClibc && !BR2_TOOLCHAIN_EXTERNAL_UCLIBC + +comment "profiling support not available with uClibc-based toolchain" + depends on BR2_TOOLCHAIN_BUILDROOT || BR2_TOOLCHAIN_CTNG_uClibc || BR2_TOOLCHAIN_EXTERNAL_UCLIBC config BR2_PACKAGE_GPSD_NTP_SHM bool "NTP time hinting support"