Patchwork [ARM] Skip gcc.dg/torture/stackalign/builtin-apply-2.c for ARM hard-float ABI

login
register
mail settings
Submitter Julian Brown
Date July 23, 2012, 12:17 p.m.
Message ID <20120723131706.1c0af756@octopus>
Download mbox | patch
Permalink /patch/172649/
State New
Headers show

Comments

Julian Brown - July 23, 2012, 12:17 p.m.
Hi,

The test case gcc.dg/torture/stackalign/builtin-apply-2.c makes
assumptions which cannot be met for __builtin_apply for the ARM
hard-float ABI variant. This patch simply skips the test in that case.

Tested (stackalign.exp only) for ARMv4t -marm/-mthumb/-mfloat-abi=hard.
The previously-failing test gets skipped as expected with the patch.
(This is another one that we've had locally for a while.)

OK to apply?

Julian

ChangeLog

    gcc/testsuite/
    * gcc.dg/torture/stackalign/builtin-apply-2.c: Skip for
    hard-float ARM.
Richard Earnshaw - July 23, 2012, 1:40 p.m.
On 23/07/12 13:17, Julian Brown wrote:
> Hi,
> 
> The test case gcc.dg/torture/stackalign/builtin-apply-2.c makes
> assumptions which cannot be met for __builtin_apply for the ARM
> hard-float ABI variant. This patch simply skips the test in that case.
> 
> Tested (stackalign.exp only) for ARMv4t -marm/-mthumb/-mfloat-abi=hard.
> The previously-failing test gets skipped as expected with the patch.
> (This is another one that we've had locally for a while.)
> 
> OK to apply?
> 
> Julian
> 
> ChangeLog
> 
>     gcc/testsuite/
>     * gcc.dg/torture/stackalign/builtin-apply-2.c: Skip for
>     hard-float ARM.
> 
> 
> skip-builtin-apply-2-for-hardfloat-arm-2.diff
> 

Hmm, I think this won't work for platforms like fedora/arm, where
-mfloat-abi=hard is the default.

R.
> 
> Index: gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c	(revision 189779)
> +++ gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c	(working copy)
> @@ -5,6 +5,8 @@
>     with pre-pushed arguments (e.g. SPARC).  */
>  
>  /* { dg-do run } */
> +
> +/* { dg-skip-if "Variadic funcs use Base AAPCS.  Normal funcs use VFP variant." { "arm*-*-*" } { "-mfloat-abi=hard" } { "" } } */
>     
>  
>  #define INTEGER_ARG  5
>

Patch

Index: gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c
===================================================================
--- gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c	(revision 189779)
+++ gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c	(working copy)
@@ -5,6 +5,8 @@ 
    with pre-pushed arguments (e.g. SPARC).  */
 
 /* { dg-do run } */
+
+/* { dg-skip-if "Variadic funcs use Base AAPCS.  Normal funcs use VFP variant." { "arm*-*-*" } { "-mfloat-abi=hard" } { "" } } */
    
 
 #define INTEGER_ARG  5