Patchwork [20/25] gpio/gpio-omap: make platformdata used as *of_device_id.data const

login
register
mail settings
Submitter Uwe Kleine-König
Date July 23, 2012, 9:13 a.m.
Message ID <1343034810-3386-21-git-send-email-u.kleine-koenig@pengutronix.de>
Download mbox | patch
Permalink /patch/172604/
State New
Headers show

Comments

Uwe Kleine-König - July 23, 2012, 9:13 a.m.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/gpio/gpio-omap.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Linus Walleij - July 29, 2012, 4:15 p.m.
On Mon, Jul 23, 2012 at 11:13 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:

> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

FWIW:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

But Kevin+Santosh maintains this driver so you need their ACK on the
patch.

Yours,
Linus Walleij
Santosh Shilimkar - July 29, 2012, 9:27 p.m.
On Mon, Jul 23, 2012 at 11:13 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
A line of description at least in the change log would be good otherwise
patch is fine to me. Thanks.

Acked-by: Santosh.shilimkar<santosh.shilimkar@ti.com>
Uwe Kleine-König - July 30, 2012, 7:17 a.m.
On Sun, Jul 29, 2012 at 11:27:57PM +0200, Shilimkar, Santosh wrote:
> On Mon, Jul 23, 2012 at 11:13 AM, Uwe Kleine-König
> <u.kleine-koenig@pengutronix.de> wrote:
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> A line of description at least in the change log would be good otherwise
> patch is fine to me. Thanks.
I added:

	Since of_device_id.data is declared as a pointer to const data a
	few more consts can be added in this driver.

> Acked-by: Santosh.shilimkar<santosh.shilimkar@ti.com>
I assume your real name is "Santosh Shilimkar" and not
"Santosh.shilimkar", isn't it?

Best regards
Uwe
Santosh Shilimkar - July 30, 2012, 7:20 a.m.
On Mon, Jul 30, 2012 at 9:17 AM, Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> On Sun, Jul 29, 2012 at 11:27:57PM +0200, Shilimkar, Santosh wrote:
>> On Mon, Jul 23, 2012 at 11:13 AM, Uwe Kleine-König
>> <u.kleine-koenig@pengutronix.de> wrote:
>> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> > ---
>> A line of description at least in the change log would be good otherwise
>> patch is fine to me. Thanks.
> I added:
>
>         Since of_device_id.data is declared as a pointer to const data a
>         few more consts can be added in this driver.
>
ok.

>> Acked-by: Santosh.shilimkar<santosh.shilimkar@ti.com>
> I assume your real name is "Santosh Shilimkar" and not
> "Santosh.shilimkar", isn't it?
>
Yes :-)
Thanks for correcting it.

Regards
Santosh

Patch

diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 019cb7b..12ab547 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -1430,19 +1430,19 @@  static struct omap_gpio_reg_offs omap4_gpio_regs = {
 	.fallingdetect =	OMAP4_GPIO_FALLINGDETECT,
 };
 
-static struct omap_gpio_platform_data omap2_pdata = {
+const static struct omap_gpio_platform_data omap2_pdata = {
 	.regs = &omap2_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = false,
 };
 
-static struct omap_gpio_platform_data omap3_pdata = {
+const static struct omap_gpio_platform_data omap3_pdata = {
 	.regs = &omap2_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = true,
 };
 
-static struct omap_gpio_platform_data omap4_pdata = {
+const static struct omap_gpio_platform_data omap4_pdata = {
 	.regs = &omap4_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = true,