Patchwork ARM: mxc: Include missing irqs.h header

login
register
mail settings
Submitter Fabio Estevam
Date July 23, 2012, 7:41 a.m.
Message ID <1343029278-11654-1-git-send-email-festevam@gmail.com>
Download mbox | patch
Permalink /patch/172563/
State New
Headers show

Comments

Fabio Estevam - July 23, 2012, 7:41 a.m.
From: Fabio Estevam <fabio.estevam@freescale.com>

Include irqs.h in order to fix the following build error:

arch/arm/plat-mxc/tzic.c:195:11: error: 'FIQ_START' undeclared (first use in this function)

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/plat-mxc/tzic.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Dirk Behme - July 27, 2012, 9:02 a.m.
On 23.07.2012 09:41, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Include irqs.h in order to fix the following build error:
> 
> arch/arm/plat-mxc/tzic.c:195:11: error: 'FIQ_START' undeclared (first use in this function)
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Acked-by: Dirk Behme <dirk.behme@de.bosch.com>

Could we make sure that this patch goes into mainline asap?

Recent mainline imx_v6_v7_defconfig doesn't build without this patch.

Many thanks and best regards

Dirk

P.S.: It seems that Shawn is on holiday. Could anybody help?

> ---
>  arch/arm/plat-mxc/tzic.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/tzic.c b/arch/arm/plat-mxc/tzic.c
> index c219317..3ed1adb 100644
> --- a/arch/arm/plat-mxc/tzic.c
> +++ b/arch/arm/plat-mxc/tzic.c
> @@ -23,6 +23,7 @@
>  
>  #include <mach/hardware.h>
>  #include <mach/common.h>
> +#include <mach/irqs.h>
>  
>  #include "irq-common.h"
>
Fabio Estevam - July 27, 2012, 10:11 a.m.
Hi Sascha,

On Fri, Jul 27, 2012 at 6:02 AM, Dirk Behme <dirk.behme@de.bosch.com> wrote:

> P.S.: It seems that Shawn is on holiday. Could anybody help?

Could you please help to apply this patch?

Thanks,

Fabio Estevam
Shawn Guo - July 28, 2012, 11:14 a.m.
On Mon, Jul 23, 2012 at 04:41:18AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Include irqs.h in order to fix the following build error:
> 
> arch/arm/plat-mxc/tzic.c:195:11: error: 'FIQ_START' undeclared (first use in this function)
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Thanks for the patch.  Will send it to arm-soc shortly.

Regards,
Shawn

> ---
>  arch/arm/plat-mxc/tzic.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-mxc/tzic.c b/arch/arm/plat-mxc/tzic.c
> index c219317..3ed1adb 100644
> --- a/arch/arm/plat-mxc/tzic.c
> +++ b/arch/arm/plat-mxc/tzic.c
> @@ -23,6 +23,7 @@
>  
>  #include <mach/hardware.h>
>  #include <mach/common.h>
> +#include <mach/irqs.h>
>  
>  #include "irq-common.h"
>  
> -- 
> 1.7.1
>
Shawn Guo - July 28, 2012, 3:44 p.m.
On Sat, Jul 28, 2012 at 07:14:24PM +0800, Shawn Guo wrote:
> On Mon, Jul 23, 2012 at 04:41:18AM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Include irqs.h in order to fix the following build error:
> > 
> > arch/arm/plat-mxc/tzic.c:195:11: error: 'FIQ_START' undeclared (first use in this function)
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Thanks for the patch.  Will send it to arm-soc shortly.
> 
Olof,

I just noticed you had sent the first batch fixes for merge window
fallout.  Unfortunately, this is another one.  Will there be a second
batch fixes targeting -rc1?  If so, please help pick up this one,
otherwise, I will queue it for later -rc.
Olof Johansson - July 28, 2012, 9:27 p.m.
Hi,

On Sat, Jul 28, 2012 at 8:44 AM, Shawn Guo <shawn.guo@linaro.org> wrote:
> On Sat, Jul 28, 2012 at 07:14:24PM +0800, Shawn Guo wrote:
>> On Mon, Jul 23, 2012 at 04:41:18AM -0300, Fabio Estevam wrote:
>> > From: Fabio Estevam <fabio.estevam@freescale.com>
>> >
>> > Include irqs.h in order to fix the following build error:
>> >
>> > arch/arm/plat-mxc/tzic.c:195:11: error: 'FIQ_START' undeclared (first use in this function)
>> >
>> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Thanks for the patch.  Will send it to arm-soc shortly.
>>
> Olof,
>
> I just noticed you had sent the first batch fixes for merge window
> fallout.  Unfortunately, this is another one.  Will there be a second
> batch fixes targeting -rc1?  If so, please help pick up this one,
> otherwise, I will queue it for later -rc.

Applied to fixes, so it'll make it in the next batch whenever it is.
Likely before -rc1.


-Olof

Patch

diff --git a/arch/arm/plat-mxc/tzic.c b/arch/arm/plat-mxc/tzic.c
index c219317..3ed1adb 100644
--- a/arch/arm/plat-mxc/tzic.c
+++ b/arch/arm/plat-mxc/tzic.c
@@ -23,6 +23,7 @@ 
 
 #include <mach/hardware.h>
 #include <mach/common.h>
+#include <mach/irqs.h>
 
 #include "irq-common.h"