From patchwork Mon Jul 23 03:44:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Samuel Martin X-Patchwork-Id: 172538 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ozlabs.org (Postfix) with ESMTP id D0DFF2C011C for ; Mon, 23 Jul 2012 13:45:23 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id DC1B98C89B; Mon, 23 Jul 2012 03:45:20 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BMH6oBMebXML; Mon, 23 Jul 2012 03:45:15 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 3B5688AEBE; Mon, 23 Jul 2012 03:45:14 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (whitealder.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 002068F753 for ; Mon, 23 Jul 2012 03:45:13 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id CA3898AEBE for ; Mon, 23 Jul 2012 03:45:12 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K-p6zb4dEVAx for ; Mon, 23 Jul 2012 03:45:10 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-yw0-f43.google.com (mail-yw0-f43.google.com [209.85.213.43]) by whitealder.osuosl.org (Postfix) with ESMTPS id 53E4E89F89 for ; Mon, 23 Jul 2012 03:45:10 +0000 (UTC) Received: by yhl10 with SMTP id 10so9413563yhl.16 for ; Sun, 22 Jul 2012 20:45:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=7gTNsB/A+OOVvn7nv1KaGWoYfXtrOcuTGCLUFa0qg7Y=; b=hxdWfPGsT7f8pmm0xFnuQ33QzbS2Wu9kbwKmPjNKZeTu7y2yhorb0TtKG0vgLN9If7 kuwriJmb51goyxTel7Gn5jTodqxJKXlKcQhMvkcblQ93rSs5kJ3NHv0w+StBEZAh8yGZ C7F1nyqzp9zY+5/dRWvZfUSaGoC0eggaDy+7OKysUFsSJBB3ijPB9BYoafbn22yXrmXM aXqyzSHOK25t+O4NZ11t+KKrXW9R49cBKBXxq5kSnE7TCLj3dTGK1wR3jG9Xbwm5C6ll XeWXqutVSVZlEkFxA/m57IXxlv/wynAlW4VuzbGELTlkqselAReSqtT9gJwXVkMg2fp0 YtvQ== Received: by 10.66.72.163 with SMTP id e3mr27612538pav.42.1343015108805; Sun, 22 Jul 2012 20:45:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.134.6 with HTTP; Sun, 22 Jul 2012 20:44:28 -0700 (PDT) In-Reply-To: References: <66a7689f733357af7bb277467bc2198817fc9b69.1342732829.git.thomas.petazzoni@free-electrons.com> From: Samuel Martin Date: Mon, 23 Jul 2012 05:44:28 +0200 Message-ID: To: Thomas Petazzoni Cc: buildroot@busybox.net, Maxime Ripard Subject: Re: [Buildroot] [PATCH 5/5] gettext: convert to autotools-package X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: buildroot-bounces@busybox.net Sender: buildroot-bounces@busybox.net Hi, 2012/7/22 Samuel Martin : [...] > ifeq ($(BR2_PACKAGE_GETTEXT_TOOLS),) > ifeq ($(BR2_ENABLE_LOCALE)\ > $(BR2_TOOLCHAIN_BUILDROOT)$(BR2_TOOLCHAIN_CTNG_uClibc)\ > $(BR2_TOOLCHAIN_EXTERNAL_UCLIBC)$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC),yy) Just realize that this statement can be simplify like that: ifeq ($(BR2_ENABLE_LOCALE)$(BR2_NEEDS_GETTEXT),yy) In this case, maybe BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC should trigger BR2_NEEDS_GETTEXT too? Tell me if you need I post a proper patch. Cheers, diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in index cc7b4de..4f1c8fb 100644 --- a/toolchain/toolchain-common.in +++ b/toolchain/toolchain-common.in @@ -86,6 +86,7 @@ config BR2_NEEDS_GETTEXT bool default y if BR2_TOOLCHAIN_BUILDROOT default y if BR2_TOOLCHAIN_EXTERNAL_UCLIBC + default y if BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC default y if BR2_TOOLCHAIN_CTNG_uClibc config BR2_NEEDS_GETTEXT_IF_LOCALE