Patchwork [5/5] gettext: convert to autotools-package

login
register
mail settings
Submitter Samuel Martin
Date July 23, 2012, 3:44 a.m.
Message ID <CAHXCMMLsfSjtf2Cfx=kQHqEgKR8h5Yc_QHRUcy9+bdVnKLVwaA@mail.gmail.com>
Download mbox | patch
Permalink /patch/172538/
State Superseded
Headers show

Comments

Samuel Martin - July 23, 2012, 3:44 a.m.
Hi,

2012/7/22 Samuel Martin <s.martin49@gmail.com>:
[...]
> ifeq ($(BR2_PACKAGE_GETTEXT_TOOLS),)

> ifeq ($(BR2_ENABLE_LOCALE)\
> $(BR2_TOOLCHAIN_BUILDROOT)$(BR2_TOOLCHAIN_CTNG_uClibc)\
> $(BR2_TOOLCHAIN_EXTERNAL_UCLIBC)$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC),yy)
Just realize that this statement can be simplify like that:
ifeq ($(BR2_ENABLE_LOCALE)$(BR2_NEEDS_GETTEXT),yy)

In this case, maybe BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC should
trigger BR2_NEEDS_GETTEXT too?



Tell me if you need I post a proper patch.

Cheers,
Thomas Petazzoni - July 23, 2012, 7:26 a.m.
Le Mon, 23 Jul 2012 05:44:28 +0200,
Samuel Martin <s.martin49@gmail.com> a écrit :

> > ifeq ($(BR2_ENABLE_LOCALE)\
> > $(BR2_TOOLCHAIN_BUILDROOT)$(BR2_TOOLCHAIN_CTNG_uClibc)\
> > $(BR2_TOOLCHAIN_EXTERNAL_UCLIBC)$(BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC),yy)
> Just realize that this statement can be simplify like that:
> ifeq ($(BR2_ENABLE_LOCALE)$(BR2_NEEDS_GETTEXT),yy)

Yes, I will think about this in more details.

> In this case, maybe BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC should
> trigger BR2_NEEDS_GETTEXT too?

No, because BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC already selects
BR2_TOOLCHAIN_EXTERNAL_UCLIBC. Basically BR2_TOOLCHAIN_EXTERNAL_UCLIBC
is an hidden bool which is selected either by the external toolchain
profiles (when they are uClibc based) and by the
BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC choice.

Best regards,

Thomas

Patch

diff --git a/toolchain/toolchain-common.in b/toolchain/toolchain-common.in
index cc7b4de..4f1c8fb 100644
--- a/toolchain/toolchain-common.in
+++ b/toolchain/toolchain-common.in
@@ -86,6 +86,7 @@  config BR2_NEEDS_GETTEXT
 	bool
 	default y if BR2_TOOLCHAIN_BUILDROOT
 	default y if BR2_TOOLCHAIN_EXTERNAL_UCLIBC
+	default y if BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC
 	default y if BR2_TOOLCHAIN_CTNG_uClibc

 config BR2_NEEDS_GETTEXT_IF_LOCALE