| Message ID | 20120722.123733.1898891964192153293.davem@davemloft.net |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sun, 2012-07-22 at 12:37 -0700, David Miller wrote: > From: David Miller <davem@davemloft.net> > Date: Sun, 22 Jul 2012 12:24:05 -0700 (PDT) > > > From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> > > Date: Sat, 21 Jul 2012 16:08:49 -0700 > > > >> This series contains updates to ixgbe and ixgbevf. > >> > >> The following are changes since commit > 186e868786f97c8026f0a81400b451ace306b3a4: > >> forcedeth: spin_unlock_irq in interrupt handler fix > >> and are available in the git repository at: > >> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next > master > > > > Pulled, thanks Jeff. > > Can you guys actually build test this stuff? I did, but it appears I did not have PCI_IOV enabled. That was my bad, sorry.
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Date: Sun, 22 Jul 2012 14:39:53 -0700 > On Sun, 2012-07-22 at 12:37 -0700, David Miller wrote: >> From: David Miller <davem@davemloft.net> >> Date: Sun, 22 Jul 2012 12:24:05 -0700 (PDT) >> >> > From: Jeff Kirsher <jeffrey.t.kirsher@intel.com> >> > Date: Sat, 21 Jul 2012 16:08:49 -0700 >> > >> >> This series contains updates to ixgbe and ixgbevf. >> >> >> >> The following are changes since commit >> 186e868786f97c8026f0a81400b451ace306b3a4: >> >> forcedeth: spin_unlock_irq in interrupt handler fix >> >> and are available in the git repository at: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/net-next >> master >> > >> > Pulled, thanks Jeff. >> >> Can you guys actually build test this stuff? > > I did, but it appears I did not have PCI_IOV enabled. That was my bad, > sorry. If you're not doing "allmodconfig" builds, there are by definition parts you are not testing. It's the first thing I do with any change I apply. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
==================== [PATCH] ixgbe: Fix build with PCI_IOV enabled. Signed-off-by: David S. Miller <davem@davemloft.net> --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c index 47b2ce7..4fea871 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c @@ -236,7 +236,7 @@ void ixgbe_disable_sriov(struct ixgbe_adapter *adapter) if (ixgbe_vfs_are_assigned(adapter)) { e_dev_warn("Unloading driver while VFs are assigned - VFs will not be deallocated\n"); return; - + } /* disable iov and allow time for transactions to clear */ pci_disable_sriov(adapter->pdev); #endif