From patchwork Sun Jul 22 07:46:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zheng Liu X-Patchwork-Id: 172489 Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C043B2C0193 for ; Sun, 22 Jul 2012 17:39:03 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751445Ab2GVHi7 (ORCPT ); Sun, 22 Jul 2012 03:38:59 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:36677 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193Ab2GVHi0 (ORCPT ); Sun, 22 Jul 2012 03:38:26 -0400 Received: by mail-pb0-f46.google.com with SMTP id rp8so8900821pbb.19 for ; Sun, 22 Jul 2012 00:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=pIz+n27Fg+0Di694jaYD+ugrP+l1YjSGEaFaVaVOXqo=; b=hQpri1uE7UlFTn86PcV6K5mLHw6Gomvo6m8sy7N22fCAA30U5GVrpJLQCkPJU9jS3d RQy7JKPzhdkkv5f2s6YnMThxryShlL0qnF7MEr7ymQ4mt/EI9gRnOsx6PF3dPt0pQhvb ZRdc+lx6W9mq6OuxtzPx6COIFlAXLbbKRMJi8TnH7U6ddk3MXL5O9gwbz3IvsgjH3HBI YXXHpwZRcOlVdPWdgEUwxmRZ9VTb2u2TKJ9hgJpwWI8k8fOSu8abKImppS/1sqGpiZOs bDOKOi7J37h8Hqly7vNELTJoh0au8fv1XXXoxkt07rMQHr4sCH1GkiIMFINMHx5RNr5R Ozxg== Received: by 10.68.223.35 with SMTP id qr3mr26843289pbc.83.1342942706517; Sun, 22 Jul 2012 00:38:26 -0700 (PDT) Received: from localhost.localdomain ([182.92.247.2]) by mx.google.com with ESMTPS id ru10sm7481626pbc.50.2012.07.22.00.38.24 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 22 Jul 2012 00:38:26 -0700 (PDT) From: Zheng Liu To: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: xiaoqiangnk@gmail.com, achender@linux.vnet.ibm.com, wenqing.lz@taobao.com Subject: [RFC][PATCH 09/10 v1] ext4: don't need to writeout all dirty pages in punch hole Date: Sun, 22 Jul 2012 15:46:06 +0800 Message-Id: <1342943167-12153-10-git-send-email-wenqing.lz@taobao.com> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1342943167-12153-1-git-send-email-wenqing.lz@taobao.com> References: <1342943167-12153-1-git-send-email-wenqing.lz@taobao.com> Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org From: Zheng Liu Now we don't need to writeout all dirty pages when punching a hole. The i_mutex locking is taken to avoid concurrent writes. In truncate_pagecache_range, all pages in this hole is released, and ext4_es_remove_space is called to update extent status tree. Signed-off-by: Zheng Liu --- fs/ext4/extents.c | 28 ++++++++++++---------------- 1 files changed, 12 insertions(+), 16 deletions(-) diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c index f2c5294..2a526b4 100644 --- a/fs/ext4/extents.c +++ b/fs/ext4/extents.c @@ -4529,9 +4529,11 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length) loff_t first_page_offset, last_page_offset; int credits, err = 0; + mutex_lock(&inode->i_mutex); + /* No need to punch hole beyond i_size */ if (offset >= inode->i_size) - return 0; + goto error; /* * If the hole extends beyond i_size, set the hole @@ -4549,18 +4551,6 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length) first_page_offset = first_page << PAGE_CACHE_SHIFT; last_page_offset = last_page << PAGE_CACHE_SHIFT; - /* - * Write out all dirty pages to avoid race conditions - * Then release them. - */ - if (mapping->nrpages && mapping_tagged(mapping, PAGECACHE_TAG_DIRTY)) { - err = filemap_write_and_wait_range(mapping, - offset, offset + length - 1); - - if (err) - return err; - } - /* Now release the pages */ if (last_page_offset > first_page_offset) { truncate_pagecache_range(inode, first_page_offset, @@ -4572,12 +4562,14 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length) credits = ext4_writepage_trans_blocks(inode); handle = ext4_journal_start(inode, credits); - if (IS_ERR(handle)) - return PTR_ERR(handle); + if (IS_ERR(handle)) { + err = PTR_ERR(handle); + goto error; + } err = ext4_orphan_add(handle, inode); if (err) - goto out; + goto error; /* * Now we need to zero out the non-page-aligned data in the @@ -4652,6 +4644,8 @@ int ext4_ext_punch_hole(struct file *file, loff_t offset, loff_t length) ext4_ext_invalidate_cache(inode); ext4_discard_preallocations(inode); + err = ext4_es_remove_space(inode, first_block, + stop_block - first_block); err = ext4_ext_remove_space(inode, first_block, stop_block - 1); ext4_ext_invalidate_cache(inode); @@ -4667,6 +4661,8 @@ out: inode->i_mtime = inode->i_ctime = ext4_current_time(inode); ext4_mark_inode_dirty(handle, inode); ext4_journal_stop(handle); +error: + mutex_unlock(&inode->i_mutex); return err; } int ext4_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,