Patchwork data: klog.json: make the _OSC failure advice more general and hand-wavy

login
register
mail settings
Submitter Colin King
Date July 20, 2012, 11:01 p.m.
Message ID <1342825292-24017-1-git-send-email-colin.king@canonical.com>
Download mbox | patch
Permalink /patch/172390/
State Accepted
Headers show

Comments

Colin King - July 20, 2012, 11:01 p.m.
From: Colin Ian King <colin.king@canonical.com>

Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 data/klog.json |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Keng-Yu Lin - July 23, 2012, 5:58 a.m.
On Sat, Jul 21, 2012 at 7:01 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  data/klog.json |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index e1a9143..a1f6c62 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -233,7 +233,7 @@
>     "log_level": "LOG_LEVEL_CRITICAL",
>     "tag": "FWTS_TAG_ACPI",
>     "pattern": ".*pci.*ACPI _OSC request failed.*returned control mask",
> -   "advice": "The _OSC method evaluation failed and the ACPI _OSC control for PCIe was not granted. The kernel had to disable Active State Power Management (ASPM) which means that PCIe power management is not optimally configured."
> +   "advice": "The _OSC method evaluation failed, which will result in disabling PCIe functionality, for example, the Linux kernel has to disable Active State Power Management (ASPM) which means that PCIe power management is not optimally configured."
>    },
>    {
>     "compare_mode": "string",
> --
> 1.7.10.4
>

Acked-by: Keng-Yu Lin <kengyu@canonical.com>
Ivan Hu - July 24, 2012, 8:18 a.m.
On 07/21/2012 07:01 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>   data/klog.json |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/data/klog.json b/data/klog.json
> index e1a9143..a1f6c62 100644
> --- a/data/klog.json
> +++ b/data/klog.json
> @@ -233,7 +233,7 @@
>      "log_level": "LOG_LEVEL_CRITICAL",
>      "tag": "FWTS_TAG_ACPI",
>      "pattern": ".*pci.*ACPI _OSC request failed.*returned control mask",
> -   "advice": "The _OSC method evaluation failed and the ACPI _OSC control for PCIe was not granted. The kernel had to disable Active State Power Management (ASPM) which means that PCIe power management is not optimally configured."
> +   "advice": "The _OSC method evaluation failed, which will result in disabling PCIe functionality, for example, the Linux kernel has to disable Active State Power Management (ASPM) which means that PCIe power management is not optimally configured."
>     },
>     {
>      "compare_mode": "string",
>

Acked-by: Ivan Hu <ivan.hu@canonical.com>

Patch

diff --git a/data/klog.json b/data/klog.json
index e1a9143..a1f6c62 100644
--- a/data/klog.json
+++ b/data/klog.json
@@ -233,7 +233,7 @@ 
    "log_level": "LOG_LEVEL_CRITICAL",
    "tag": "FWTS_TAG_ACPI",
    "pattern": ".*pci.*ACPI _OSC request failed.*returned control mask",
-   "advice": "The _OSC method evaluation failed and the ACPI _OSC control for PCIe was not granted. The kernel had to disable Active State Power Management (ASPM) which means that PCIe power management is not optimally configured."
+   "advice": "The _OSC method evaluation failed, which will result in disabling PCIe functionality, for example, the Linux kernel has to disable Active State Power Management (ASPM) which means that PCIe power management is not optimally configured."
   },
   {
    "compare_mode": "string",