| Submitter | Anthony Liguori |
|---|---|
| Date | July 20, 2012, 9:14 p.m. |
| Message ID | <1342818861-2245-1-git-send-email-aliguori@us.ibm.com> |
| Download | mbox | patch |
| Permalink | /patch/172351/ |
| State | New |
| Headers | show |
Comments
Am 20.07.2012 23:14, schrieb Anthony Liguori: > Handle is uninitialized which causes the configure check to fail. > > Cc: malc<av1474@comtv.ru> > Signed-off-by: Anthony Liguori<aliguori@us.ibm.com> > --- > configure | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index cef0a71..8335117 100755 > --- a/configure > +++ b/configure > @@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do > case $drv in > alsa) > audio_drv_probe $drv alsa/asoundlib.h -lasound \ > - "snd_pcm_t **handle; return snd_pcm_close(*handle);" > + "snd_pcm_t **handle = NULL; return snd_pcm_close(*handle);" > libs_softmmu="-lasound $libs_softmmu" > ;; > > See also http://patchwork.ozlabs.org/patch/171066/ Regards, Stefan W.
On Fri, 20 Jul 2012, Anthony Liguori wrote: > Handle is uninitialized which causes the configure check to fail. > http://patchwork.ozlabs.org/patch/171688/ Has an advantage of not expecting alsa/asoundlib.h including stddef.h > Cc: malc <av1474@comtv.ru> > Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> > --- > configure | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/configure b/configure > index cef0a71..8335117 100755 > --- a/configure > +++ b/configure > @@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do > case $drv in > alsa) > audio_drv_probe $drv alsa/asoundlib.h -lasound \ > - "snd_pcm_t **handle; return snd_pcm_close(*handle);" > + "snd_pcm_t **handle = NULL; return snd_pcm_close(*handle);" > libs_softmmu="-lasound $libs_softmmu" > ;; > >
On 20 July 2012 22:14, Anthony Liguori <aliguori@us.ibm.com> wrote:
> Handle is uninitialized which causes the configure check to fail.
Do keep up at the back :-). I posted a whole series earlier this
week which among other things fixes a whole pile of these
-Werror related configure issues.
http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg02311.html
-- PMM
Patch
diff --git a/configure b/configure index cef0a71..8335117 100755 --- a/configure +++ b/configure @@ -1888,7 +1888,7 @@ for drv in $audio_drv_list; do case $drv in alsa) audio_drv_probe $drv alsa/asoundlib.h -lasound \ - "snd_pcm_t **handle; return snd_pcm_close(*handle);" + "snd_pcm_t **handle = NULL; return snd_pcm_close(*handle);" libs_softmmu="-lasound $libs_softmmu" ;;
Handle is uninitialized which causes the configure check to fail. Cc: malc <av1474@comtv.ru> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com> --- configure | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)