Patchwork [U-Boot,1/2] kirkwood: ib62x0: Invert SATA activity LEDs

login
register
mail settings
Submitter Simon Baatz
Date July 20, 2012, 7:59 p.m.
Message ID <1342814355-25472-1-git-send-email-gmbnomis@gmail.com>
Download mbox | patch
Permalink /patch/172336/
State Accepted
Delegated to: Prafulla Wadaskar
Headers show

Comments

Simon Baatz - July 20, 2012, 7:59 p.m.
The hardware design of the IB-NAS62x0 causes the SATA activity
LEDs to be on when idle by default.  Reverse the polarity of the
activity LEDs in early init.

Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
Cc: Luka Perkov <uboot@lukaperkov.net>
Cc: Prafulla Wadaskar <prafulla@marvell.com>
---
 board/raidsonic/ib62x0/ib62x0.c |    3 +++
 board/raidsonic/ib62x0/ib62x0.h |    4 ++++
 2 files changed, 7 insertions(+)
Luka Perkov - July 21, 2012, 8 a.m.
On Fri, Jul 20, 2012 at 09:59:14PM +0200, Simon Baatz wrote:
> The hardware design of the IB-NAS62x0 causes the SATA activity
> LEDs to be on when idle by default.  Reverse the polarity of the
> activity LEDs in early init.
> 
> Signed-off-by: Simon Baatz <gmbnomis@gmail.com>
> Cc: Luka Perkov <uboot@lukaperkov.net>
> Cc: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  board/raidsonic/ib62x0/ib62x0.c |    3 +++
>  board/raidsonic/ib62x0/ib62x0.h |    4 ++++
>  2 files changed, 7 insertions(+)

Acked-by: Luka Perkov <uboot@lukaperkov.net>

Patch

diff --git a/board/raidsonic/ib62x0/ib62x0.c b/board/raidsonic/ib62x0/ib62x0.c
index 1164d6b..b7e6e41 100644
--- a/board/raidsonic/ib62x0/ib62x0.c
+++ b/board/raidsonic/ib62x0/ib62x0.c
@@ -23,6 +23,7 @@ 
 
 #include <common.h>
 #include <miiphy.h>
+#include <asm/io.h>
 #include <asm/arch/cpu.h>
 #include <asm/arch/kirkwood.h>
 #include <asm/arch/mpp.h>
@@ -41,6 +42,8 @@  int board_early_init_f(void)
 			IB62x0_OE_VAL_HIGH,
 			IB62x0_OE_LOW, IB62x0_OE_HIGH);
 
+	/* Set SATA activity LEDs to default off */
+	writel(MVSATAHC_LED_POLARITY_CTRL, MVSATAHC_LED_CONF_REG);
 	/* Multi-Purpose Pins Functionality configuration */
 	u32 kwmpp_config[] = {
 		MPP0_NF_IO2,
diff --git a/board/raidsonic/ib62x0/ib62x0.h b/board/raidsonic/ib62x0/ib62x0.h
index 0c30690..0118c2b 100644
--- a/board/raidsonic/ib62x0/ib62x0.h
+++ b/board/raidsonic/ib62x0/ib62x0.h
@@ -37,4 +37,8 @@ 
 #define MV88E1116_RGMII_TXTM_CTRL	(1 << 4)
 #define MV88E1116_RGMII_RXTM_CTRL	(1 << 5)
 
+/* SATAHC related */
+#define MVSATAHC_LED_CONF_REG       (MV_SATA_BASE + 0x2C)
+#define MVSATAHC_LED_POLARITY_CTRL  (1 << 3)
+
 #endif /* __IB62x0_H */