Patchwork mpc85xx_defconfig: add IDE support for MPC85xxCDS

login
register
mail settings
Submitter chenhui zhao
Date July 20, 2012, 12:45 p.m.
Message ID <1342788325-27609-1-git-send-email-chenhui.zhao@freescale.com>
Download mbox | patch
Permalink /patch/172250/
State Accepted
Delegated to: Kumar Gala
Headers show

Comments

chenhui zhao - July 20, 2012, 12:45 p.m.
Add IDE support for MPC85xxCDS.

Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
---
 arch/powerpc/configs/mpc85xx_defconfig |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Alan Cox - July 20, 2012, 2:09 p.m.
On Fri, 20 Jul 2012 20:45:25 +0800
Zhao Chenhui <chenhui.zhao@freescale.com> wrote:

> Add IDE support for MPC85xxCDS.
> 
> Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> ---
>  arch/powerpc/configs/mpc85xx_defconfig |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/powerpc/configs/mpc85xx_defconfig b/arch/powerpc/configs/mpc85xx_defconfig
> index 03ee911..45eda33 100644
> --- a/arch/powerpc/configs/mpc85xx_defconfig
> +++ b/arch/powerpc/configs/mpc85xx_defconfig
> @@ -105,6 +105,8 @@ CONFIG_BLK_DEV_RAM=y
>  CONFIG_BLK_DEV_RAM_SIZE=131072
>  CONFIG_MISC_DEVICES=y
>  CONFIG_EEPROM_LEGACY=y
> +CONFIG_IDE=y
> +CONFIG_BLK_DEV_VIA82CXXX=y

CONFIG_IDE is obsolete we shouldn't be adding it to anything as it will
eventually go away. Please use the ATA drivers.
chenhui zhao - July 24, 2012, 2:30 a.m.
On Fri, Jul 20, 2012 at 03:09:00PM +0100, Alan Cox wrote:
> On Fri, 20 Jul 2012 20:45:25 +0800
> Zhao Chenhui <chenhui.zhao@freescale.com> wrote:
> 
> > Add IDE support for MPC85xxCDS.
> > 
> > Signed-off-by: Zhao Chenhui <chenhui.zhao@freescale.com>
> > ---
> >  arch/powerpc/configs/mpc85xx_defconfig |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/powerpc/configs/mpc85xx_defconfig b/arch/powerpc/configs/mpc85xx_defconfig
> > index 03ee911..45eda33 100644
> > --- a/arch/powerpc/configs/mpc85xx_defconfig
> > +++ b/arch/powerpc/configs/mpc85xx_defconfig
> > @@ -105,6 +105,8 @@ CONFIG_BLK_DEV_RAM=y
> >  CONFIG_BLK_DEV_RAM_SIZE=131072
> >  CONFIG_MISC_DEVICES=y
> >  CONFIG_EEPROM_LEGACY=y
> > +CONFIG_IDE=y
> > +CONFIG_BLK_DEV_VIA82CXXX=y
> 
> CONFIG_IDE is obsolete we shouldn't be adding it to anything as it will
> eventually go away. Please use the ATA drivers.
> 

Thanks. I will replace it with the ATA driver.

-Chenhui

Patch

diff --git a/arch/powerpc/configs/mpc85xx_defconfig b/arch/powerpc/configs/mpc85xx_defconfig
index 03ee911..45eda33 100644
--- a/arch/powerpc/configs/mpc85xx_defconfig
+++ b/arch/powerpc/configs/mpc85xx_defconfig
@@ -105,6 +105,8 @@  CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_SIZE=131072
 CONFIG_MISC_DEVICES=y
 CONFIG_EEPROM_LEGACY=y
+CONFIG_IDE=y
+CONFIG_BLK_DEV_VIA82CXXX=y
 CONFIG_BLK_DEV_SD=y
 CONFIG_CHR_DEV_ST=y
 CONFIG_BLK_DEV_SR=y